[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#718761: flash-kernel: 'root=' kernel param ignored when flash-kernel package is installed



Copying Loïc Minier.

* Erik Speckman <especkman+reportbug@gmail.com> [2013-08-04 23:45]:
> 8. Read through mkinitramfs scripts and found that a hook installed by the flash-kernel package was responsible for the hook script that was setting "root=/dev/root" in conf/param.con.

> If flash-kernel isn't necessary/required on my device, I would expect it to detect that fact rather than rendering my system in an unbootable state.

How about this?  Erik, can you test the patch?

diff --git a/initramfs-tools/hooks/flash_kernel_set_root b/initramfs-tools/hooks/flash_kernel_set_root
index 2a313c7..9fb4bcc 100755
--- a/initramfs-tools/hooks/flash_kernel_set_root
+++ b/initramfs-tools/hooks/flash_kernel_set_root
@@ -102,11 +102,13 @@ if [ "$blsr" = "no" ]; then
 	# provide a default.
 	install -d $DESTDIR/conf/conf.d
 	echo "ROOT=\"$rootdev\"" > $DESTDIR/conf/conf.d/default_root
-else
+elif [ "$blsr" = "yes" ]; then
 	# The boot loader passes a bogus root= (e.g. root=/dev/ram), so
 	# override the command line parameter.
 	install -d $DESTDIR/conf
 	echo "ROOT=\"$rootdev\"" >> $DESTDIR/conf/param.conf
+else
+	echo "Warning: device $machine not supported" >&2
 fi
 
 # vim:noexpandtab shiftwidth=8

-- 
Martin Michlmayr
http://www.cyrius.com/


Reply to: