Charles Plessy <plessy@debian.org> (16/03/2013):
> Le Sun, Mar 10, 2013 at 05:39:56PM +0900, Charles Plessy a écrit :
> > Le Sun, Mar 10, 2013 at 07:59:46AM +0100, Christian PERRIER a écrit :
> > >
> > > Here, we know about the bug and solution (I haven't looked at
> > > the code but adding iw at the same place where wireless-tools
> > > are added when the installation interface is wireless should be
> > > trivial....evn for someone with extremely low C skills)....and
> > > we want this to be fixed.
> >
> > Agreed. I reassign 697890 to netcfg, then.
>
> Would it be as simple as adding iw through the followign patch ?
Thanks for the submission.
Reminds me there's an option handling fix sitting in git for netcfg.
> It looks like it is not necessary to check that the system being
> installed is using a Linux kernel, otherwise it would already be
> done for the installation of wireless-tools.
>
> diff --git a/netcfg-static.c b/netcfg-static.c
> index 4e9ca29..1987bec 100644
> --- a/netcfg-static.c
> +++ b/netcfg-static.c
> @@ -83,7 +83,7 @@ int main(int argc, char** argv)
> case WCONFIG:
> if (requested_wireless_tools == 0) {
> requested_wireless_tools = 1;
> - di_exec_shell("apt-install wireless-tools");
> + di_exec_shell("apt-install iw wireless-tools");
> }
> state = WCONFIG_ESSID;
> break;
> diff --git a/netcfg.c b/netcfg.c
> index 06c1dcf..d0c46e5 100644
> --- a/netcfg.c
> +++ b/netcfg.c
> @@ -280,7 +280,7 @@ int main(int argc, char *argv[])
>
> case WCONFIG:
> if (requested_wireless_tools == 0) {
> - di_exec_shell_log("apt-install wireless-tools");
> + di_exec_shell_log("apt-install iw wireless-tools");
> requested_wireless_tools = 1;
> }
> state = WCONFIG_ESSID;
> diff --git a/write_interface.c b/write_interface.c
> index 1aa331a..2a42d48 100644
> --- a/write_interface.c
> +++ b/write_interface.c
> @@ -55,7 +55,7 @@ static int nc_wi_wireless_options(const struct netcfg_interface *interface, FILE
> fprintf(fd, "\twpa-ssid %s\n", interface->essid);
> fprintf(fd, "\twpa-psk %s\n", interface->passphrase);
> } else {
> - fprintf(fd, "\t# wireless-* options are implemented by the wireless-tools package\n");
> + fprintf(fd, "\t# wireless-* options are implemented by the iw and wireless-tools packages\n");
> fprintf(fd, "\twireless-mode %s\n",
> (interface->mode == MANAGED) ? "managed" : "ad-hoc");
> fprintf(fd, "\twireless-essid %s\n",
I'm not sure about that part, basically because I haven't looked at
wpasupplicant yet. Are those options relevant to iw too?
> For write_interface.c, the number of characters grows from 67 to 75,
> not including the tabulation. Depending on its size, it may make
> the message too long for interfaces limited to 80 characters in
> width.
Not an issue IMHO.
Mraw,
KiBi.
Attachment:
signature.asc
Description: Digital signature