[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Reviewing/unblocking udev/175-7



Hi Marco,

reviewing udev's diff between testing and sid, I found those tiny things:

1. This one appears twice:
+  * Moved 60-persistent-input.rules back from udev-gtk-udeb to udev-udeb.
+    (Closes: #666223) 

I suspect a copy/paste failure, since 50-udev-default.rules was moved
to, but not mentioned in the changelog?

2. You want to compress only source with that, right?
+  * Compress with xz.
[debian/source/options]
+compression=xz

Otherwise you would need to add “-- -Zxz” at the end of the dh_builddeb
line. Space savings wouldn't be too huge:
kibi@kathleen:/tmp$ dcmd --deb ls -lh udev_175-[78]_amd64.changes
-rw-r--r-- 1 kibi kibi 3.0K Aug 25 22:40 gir1.2-gudev-1.0_175-7_amd64.deb
-rw-r--r-- 1 kibi kibi 2.7K Aug 25 22:43 gir1.2-gudev-1.0_175-8_amd64.deb
-rw-r--r-- 1 kibi kibi 110K Aug 25 22:40 libgudev-1.0-0_175-7_amd64.deb
-rw-r--r-- 1 kibi kibi 108K Aug 25 22:43 libgudev-1.0-0_175-8_amd64.deb
-rw-r--r-- 1 kibi kibi  44K Aug 25 22:40 libgudev-1.0-dev_175-7_amd64.deb
-rw-r--r-- 1 kibi kibi  32K Aug 25 22:43 libgudev-1.0-dev_175-8_amd64.deb
-rw-r--r-- 1 kibi kibi 123K Aug 25 22:40 libudev0_175-7_amd64.deb
-rw-r--r-- 1 kibi kibi 120K Aug 25 22:43 libudev0_175-8_amd64.deb
-rw-r--r-- 1 kibi kibi  61K Aug 25 22:40 libudev-dev_175-7_amd64.deb
-rw-r--r-- 1 kibi kibi  47K Aug 25 22:43 libudev-dev_175-8_amd64.deb
-rw-r--r-- 1 kibi kibi 341K Aug 25 22:40 udev_175-7_amd64.deb
-rw-r--r-- 1 kibi kibi 230K Aug 25 22:43 udev_175-8_amd64.deb

3. The libusb-dev epoch bump in build-depswasn't mentioned in the changelog.

4. Standards-Version was bumped with no mention in the changelog.

5. gir1.2-gudev-1.0's section was changed from libs to introspection
with no mention in the changelog.

6. udev_conf_comments wasn't mentioned in the changelog.


Even if changes which aren't mentioned in the changelog make it harder
for us to review, this looks like a nice udev release to have in wheezy,
so I've unblocked it.

(I've also built d-i images and performed some tests with the new
udebs.)

As mentioned on IRC, 17x vs. 18y for wheezy is for another day…

Mraw,
KiBi.

Attachment: signature.asc
Description: Digital signature


Reply to: