[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#674481: partman-target: Please remove /proc from generated fstab for wheezy



Package: partman-target
Version: 77
Severity: important
Tags: patch

/proc has been created as part of the default /etc/fstab for
some time.  However, this is not needed, and has been found
to be detrimental in some cases.  /proc is mounted by the
initramfs (if used), or else by the mountkernfs init script,
making the fstab entry redundant.  If the naming of the
filesystem differs to the name used in the initramfs or init
scripts, this can cause the mountall script to fail.
#425199 is an example of this.

Note this obsoletes #378984; mountkernfs now uses the
mount options from /etc/fstab for all filesystems /if present/,
meaning that no special support is required on the part of
the installer, given that the regular initscripts handle this
job in the general case--no special /proc support is required.

In short, removing /proc has zero downside--it's all handled
outside fstab by default, and has been since forever, and we
pick up the settings from /proc should there be an entry there,
so we're both backward compatible /and/ customisable by the
admin.


Regards,
Roger

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (550, 'unstable'), (500, 'testing'), (400, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
>From 5da5941d594e4d02054d9f14549e70e8af87f0fd Mon Sep 17 00:00:00 2001
From: Roger Leigh <rleigh@debian.org>
Date: Fri, 25 May 2012 00:05:52 +0100
Subject: [PATCH] create_fstab_header: Drop /proc

/proc has been created as part of the default /etc/fstab for
some time.  However, this is not needed, and has been found
to be detrimental in some cases.  /proc is mounted by the
initramfs (if used), or else by the mountkernfs init script,
making the fstab entry redundant.  If the naming of the
filesystem differs to the name used in the initramfs or init
scripts, this can cause the mountall script to fail.

Signed-off-by: Roger Leigh <rleigh@debian.org>
---
 finish.d/create_fstab_header |    2 --
 1 file changed, 2 deletions(-)

diff --git a/finish.d/create_fstab_header b/finish.d/create_fstab_header
index 8aece0d..e99fa5e 100755
--- a/finish.d/create_fstab_header
+++ b/finish.d/create_fstab_header
@@ -13,8 +13,6 @@ case `udpkg --print-os` in
 #
 EOF
 		printf "%-15s %-15s %-7s %-15s %-7s %s\n" '# <file system>' '<mount point>' '<type>' '<options>' '<dump>' '<pass>' >> /target/etc/fstab
-
-		printf "%-15s %-15s %-7s %-15s %-7s %s\n" proc /proc proc defaults 0 0 >> /target/etc/fstab
 	;;
 
 	kfreebsd)
-- 
1.7.10


Reply to: