Joey Hess wrote:
AFAICS, the grub configuration generated by otheros.sh is entirely grub-legacy syntax. If it ever worked with grub-pc it was due to luck or compatability hacks in grub-pc. So I suspect my patch fixes this bug, and that modifying otheros to use --set=root is unnecessary, and would break it when used with grub-legacy.
otheros.sh seems to work with grub-pc. So much, in fact, that it saves the day in certain cases, like a problem I'm debugging which causes the normal update-grub to write a grub.cfg with an empty otheros section. When os-prober is not installed and update_grub is rerun with grub-installer's 30_otheros, the second update_grub is good and causes the other OS-es to go in the final grub.cfg by overwriting the broken initial grub.cfg.
Also, note that os-prober is extra and the os-prober deb is *not* present on all installation media. For example, a netinst without network access will fail to install os-prober to target.