[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#348314: busybox-udeb: please enable getopt



10.03.2011 17:09, Otavio Salvador wrote:
> On Thu, Mar 10, 2011 at 12:12, Colin Watson <cjwatson@debian.org> wrote:
>> On Thu, Mar 10, 2011 at 02:37:20PM +0300, Michael Tokarev wrote:

>>> Isn't it sufficient to use getopts ash built-in?

>> No, getopts can't deal with long options, which Kickstart requires.

> What is the binary size change enabling it?

The size is relatively small:

   text	   data	    bss	    dec	    hex	filename
 222730	   1498	   8684	 232912	  38dd0	current
 224354	   1502	   8684	 234540	  3942c	+long_getopt +1624 bytes for long_getopt
 224656	   1506	   8684	 234846	  3955e	+long_getopt+mktemp  +302 bytes for mktemp

(+long_getopt - CONFIG_GETOPT + CONFIG_GETOPT_LONG_OPTIONS)

Note that we already have chown with long options and
cp with long options in busybox udeb.

   text	   data	    bss	    dec	    hex	filename
 222480	   1494	   8680	 232654	  38cce	current -longopts +getopt
 221462	   1494	   8680	 231636	  388d4	current -longopts -1268 bytes for getopt_long

(-longopts - i disabled long options for cp and chown).

/mjt



Reply to: