Robert Edmonds wrote:
> here is a new version of the patch. this one makes the reachability
> test conditional on !is_wireless_iface(), since wireless interfaces
> don't have the 802.1d forwarding delay problem.
i have now built a test d-i which includes busybox arping and the netcfg
arping patch:
http://people.debian.org/~edmonds/d-i-arping/mini-arping.iso
i have tested this in three different ways in virtualbox:
#1 - with a reachable gateway. the arping is performed, link detection
succeeds instantly. in syslog is:
Feb 9 02:46:19 main-menu[261]: INFO: Menu item 'netcfg' selected
Feb 9 02:46:19 netcfg[1368]: INFO: Starting netcfg v.1:1.60~rse0 (built 20110208-2136)
Feb 9 02:46:59 kernel: [ 83.783523] ADDRCONF(NETDEV_UP): eth0: link is not ready
Feb 9 02:46:59 kernel: [ 83.784553] e1000: eth0 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX
Feb 9 02:46:59 netcfg[1368]: INFO: executing: ip addr add 172.16.0.42/24 broadcast 172.16.0.255 dev eth0
Feb 9 02:46:59 kernel: [ 83.784989] ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
Feb 9 02:46:59 netcfg[1368]: INFO: ethtool-lite: eth0 is connected.
Feb 9 02:46:59 netcfg[1368]: ARPING to 172.16.0.1 from 172.16.0.42 via eth0
Feb 9 02:46:59 netcfg[1368]: Unicast reply from 172.16.0.1 [0:8:9b:bf:a4:3] 0.438ms
Feb 9 02:46:59 netcfg[1368]: Sent 1 probe(s) (1 broadcast(s))
Feb 9 02:46:59 netcfg[1368]: Received 1 replies (0 request(s), 0 broadcast(s))
Feb 9 02:47:11 netcfg[1368]: INFO: Detected eth0 as a hotpluggable device
#2 - with an unreachable gateway. ARPs are sent once a second, the
progress bar smoothly advances from 50% to 100% at 1%/second for 50
seconds, then the installation proceeds. (note that we could have
arping failure result in failure being returned from
netcfg_detect_link() but it is currently conservatively coded to only
delay until the gateway is reachable and not to modify the return
value.)
#3 - with a gateway that becomes reachable sometime after the arping
loop starts. as soon as the gateway becomes reachable the arping loop
terminates and the progress bar advances to 100%, then the installation
proceeds.
i have also tested this on a physical server with both DHCP and static
network configs and everything worked as expected. the potential for
breakage seems quite low.
--
Robert Edmonds
edmonds@debian.org
Attachment:
signature.asc
Description: Digital signature