[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#606147: marked as done (yaboot-installer: Use short unique OS labels returned by os-prober)

Your message dated Mon, 13 Dec 2010 06:32:15 +0000
with message-id <E1PS1xH-0002kQ-Ad@franck.debian.org>
and subject line Bug#606147: fixed in yaboot-installer 1.1.19
has caused the Debian Bug report #606147,
regarding yaboot-installer: Use short unique OS labels returned by os-prober
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
606147: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=606147
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: yaboot-installer
Tags: patch

Yaboot-installer should use short unique OS labels returned by os-prober
instead of long titles. It should add oldlabel to the label, if available.

Currently, first word from long title is actually used by yaboot. This
regularly makes duplicate labels. Current solution of prepending the
last part of the partition name to the label just adds to the confusion
as unix device/partition names are not persistent anymore.



Index: debian/postinst
===================================================================
--- debian/postinst	(revision 65533)
+++ debian/postinst	(working copy)
@@ -255,10 +255,10 @@
 	linux)
 	    IFS=:
 	    linux-boot-prober "$partition" | while read \
-		    rootpart bootpart label kernel initrd params; do
+		    rootpart bootpart oldlabel kernel initrd params; do
 		IFS="$OLDIFS"
 		info "linux-boot-probed:" \
-		     "$rootpart:$bootpart:$label:$kernel:$initrd:$params"
+		     "$rootpart:$bootpart:$oldlabel:$kernel:$initrd:$params"
 		ofrootpart="$(map_of_path "$mappedpartition")" || continue
 		debug "OF root partition: $ofrootpart"
 		# bootpart may or may not be in devfs syntax.
@@ -267,13 +267,8 @@
 		debug "mapped boot partition: $mappedbootpart"
 		ofbootpart="$(map_of_path "$mappedbootpart")" || continue
 		debug "OF boot partition: $ofbootpart"
-		if [ -z "$label" ]; then
-		    label="$title"
-		fi
-		# Prepend the last part of the partition name to the label,
-		# for uniqueness and (I hope) clarity, given that we don't
-		# have a way to display a useful description in yaboot.
-		label="${mappedbootpart##*/}-$label"
+		# Add oldlabel to os-prober provided label, if available.
+		label="$label${oldlabel:+-${oldlabel}}"
 		if echo "$kernel" | grep -q '^/boot/' && \
 		   [ "$mappedbootpart" != "$mappedpartition" ]; then
 		    # separate /boot partition

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message --- 
Source: yaboot-installer
Source-Version: 1.1.19

We believe that the bug you reported is fixed in the latest version of
yaboot-installer, which is due to be installed in the Debian FTP archive:

yaboot-installer_1.1.19.dsc
  to main/y/yaboot-installer/yaboot-installer_1.1.19.dsc
yaboot-installer_1.1.19.tar.gz
  to main/y/yaboot-installer/yaboot-installer_1.1.19.tar.gz
yaboot-installer_1.1.19_powerpc.udeb
  to main/y/yaboot-installer/yaboot-installer_1.1.19_powerpc.udeb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 606147@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Milan Kupcevic <milan@physics.harvard.edu> (supplier of updated yaboot-installer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 11 Dec 2010 22:42:27 -0500
Source: yaboot-installer
Binary: yaboot-installer
Architecture: source powerpc
Version: 1.1.19
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Milan Kupcevic <milan@physics.harvard.edu>
Description: 
 yaboot-installer - Install yaboot on a hard disk (udeb)
Closes: 572925 605932 606147
Changes: 
 yaboot-installer (1.1.19) unstable; urgency=low
 .
   [ Milan Kupcevic ]
   * Use short unique OS labels returned by os-prober instead of long titles.
     Add oldlabel to the label, if available.  (Closes: #606147)
   * Use persistent device naming symlinks and UUID/LABEL tags instead of unix
     block device names.  (Closes: #572925, #605932)
 .
   [ Updated translations ]
   * Lao (lo.po) by Anousak Souphavanh
   * Sinhala (si.po) by Danishka Navin
   * Slovenian (sl.po) by Vanja Cvelbar
Checksums-Sha1: 
 3984d32e4e29e9ab991da258d809414a74e2edc3 1257 yaboot-installer_1.1.19.dsc
 2f335013085c6a9ff296bcc001e97e67d3311b97 118196 yaboot-installer_1.1.19.tar.gz
 dcf739c932f04f5a5b5bdab630886c09a1661256 92786 yaboot-installer_1.1.19_powerpc.udeb
Checksums-Sha256: 
 af88af2b9931c1a406c32e4b7807d26b6e5aab59a1a4e4d9a9369ec8656b138b 1257 yaboot-installer_1.1.19.dsc
 4300dd528bc77ed87d459fc02f5704257a314b7d22e6a155264600c8a0f73f14 118196 yaboot-installer_1.1.19.tar.gz
 f74d85a8a6cdb9f688b87d1ccfa457897d3f18b24e8aedcb0270ab8f637b11ea 92786 yaboot-installer_1.1.19_powerpc.udeb
Files: 
 e4298422ab2caae1dfe07c383cf894ff 1257 debian-installer standard yaboot-installer_1.1.19.dsc
 e60796959c55a6d1bc088ae667ea1221 118196 debian-installer standard yaboot-installer_1.1.19.tar.gz
 ba6fdfa9b7568862df7bfc6b7a001f84 92786 debian-installer standard yaboot-installer_1.1.19_powerpc.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQEVAwUBTQW8j00yN7tZsYcyAQhbzQf9Fqb9EbV/woNYtz0WbzH7hou5/SE5Asy4
C1dg9+5XMzPKQeCVDoMecu8emtIresAL05McNZXyrA9qRhh1rftIs/+Xwf9q1jv7
g+eCN3Yc+OakvWQDL/Cwuz3XemPEGKhzVZKlOvveGKXehGlRKNMpYg1o74PcxFto
1hdAzI7y/d5Q4268Bwtex36bV0TA+VxdaY9//PFr/pvbuAV/Q9hAl4L2Rhd4jz+r
CxeupeEiOUw2SPRQ9tRO55F3VF4vDwVR3LIAi5n05m6ue7BluId8ykoaTqOKnjuz
m26Ikn0/KhiS6xe4pJqDeZdoi/zQApYkkI3EVsTOkgGBqcKfZ5UMZQ==
=Q97q
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: