[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#470812: marked as done (please replace maxleases in example config with correct value)

Your message dated Tue, 07 Dec 2010 23:13:17 +0300
with message-id <4CFE955D.6080504@msgid.tls.msk.ru>
and subject line Re: Bug#470812: please replace maxleases in example config with correct value
has caused the Debian Bug report #470812,
regarding please replace maxleases in example config with correct value
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
470812: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=470812
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: udhcpd
Version: 0.9.8cvs20050303-2
Severity: minor
Tags: patch

* Starting from the assumption, that it is a good practice to provide
  working and/or correct default/example configurations in packages, that
  make the user's life easier, I suggest, that udhcpd's example
  configuration be adapted to that principle.

  A virgin install of udhcpd will complain that:

  "max leases value (254) is not sane, setting to 235 instead"

  I suggest to fix that reported problem in the example/default config.

* The attached patch contains additionaly correction to the IP addresses
  of the optional various network servers, that all have IP addresses
  outside of the configured network.

* I see that there are several trivial bugs reported against your
  package that are fairly old. Do you mind if I fix those additionaly to
  this bug here and NMU your package? (#387732, #409363).

Thanks,
*t

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.22-3-686 (SMP w/1 CPU core)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash

Versions of packages udhcpd depends on:
ii  libc6                         2.7-6      GNU C Library: Shared libraries

udhcpd recommends no packages.

--- udhcpd.conf.orig	2008-03-13 19:14:00.000000000 +0100
+++ udhcpd.conf	2008-03-13 19:14:05.000000000 +0100
@@ -14,7 +14,7 @@
 # The maximim number of leases (includes addressesd reserved
 # by OFFER's, DECLINE's, and ARP conficts
 
-#max_leases	254		#default: 254
+max_leases	235		#default: 254
 
 
 # If remaining is true (default), udhcpd will store the time
@@ -83,10 +83,10 @@
 # lines. The only option with a default is 'lease'.
 
 #Examles
-opt	dns	192.168.10.2 192.168.10.10
+opt	dns	192.168.0.2 192.168.0.10
 option	subnet	255.255.255.0
-opt	router	192.168.10.2
-opt	wins	192.168.10.10
+opt	router	192.168.0.2
+opt	wins	192.168.0.10
 option	dns	129.219.13.81	# appened to above DNS servers for a total of 3
 option	domain	local
 option	lease	864000		# 10 days of seconds

--- End Message ---
--- Begin Message --- 
Package: udhcpd
Version: 1:1.17.1-8

13.03.2008 21:25, Tomas Pospisek wrote:
> Package: udhcpd
> Version: 0.9.8cvs20050303-2
> Severity: minor
> Tags: patch
> 
> * Starting from the assumption, that it is a good practice to provide
>   working and/or correct default/example configurations in packages, that
>   make the user's life easier, I suggest, that udhcpd's example
>   configuration be adapted to that principle.
> 
>   A virgin install of udhcpd will complain that:
> 
>   "max leases value (254) is not sane, setting to 235 instead"
> 
>   I suggest to fix that reported problem in the example/default config.

The code (as of current version in squeeze) is now different,
and there's no such check anymore, default value of 254 is ok now.

> * The attached patch contains additionaly correction to the IP addresses
>   of the optional various network servers, that all have IP addresses
>   outside of the configured network.

I don't think these changes are actually necessary.  Yes,
the networks don't match, in particular (the changes you
suggests):

start           192.168.0.20    #default: 192.168.0.20
end             192.168.0.254   #default: 192.168.0.254
option  subnet  255.255.255.0

opt     dns     192.168.10.2 192.168.10.10
opt     router  192.168.10.2
opt     wins    192.168.10.10

While router at least usually located in the network
range we're talking about, the other settings (dns and
wins in this case) may be in other subnets just fine.
And as you correctly noticed this is just an example.

Maybe some day...

> * I see that there are several trivial bugs reported against your
>   package that are fairly old. Do you mind if I fix those additionaly to
>   this bug here and NMU your package? (#387732, #409363).

Working on these ;)

Thank you!

/mjt

--- End Message ---
Reply to: