[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#586871: marked as done (partman-basicfilesystems: please include Hurd support)

Your message dated Wed, 18 Aug 2010 14:47:16 +0000
with message-id <E1OljvA-0006DS-Be@franck.debian.org>
and subject line Bug#586871: fixed in partman-basicfilesystems 65
has caused the Debian Bug report #586871,
regarding partman-basicfilesystems: please include Hurd support
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
586871: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=586871
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: partman-basicfilesystems
Version: 63
Severity: normal
Usertags: gsoc2010
Tags: patch

Hello,

partman-basicfilesystems needs a few special cases to work properly
on Hurd, namely:
  - no kernel modules are needed for ext2 and vfat;
  - only 4k blocks, 128 bytes inodes are supported by ext2fs;
  - the "errors=remount-ro" option is not supported.

See the attached patch.

Thanks,
-- 
Jeremie Koenig <jk@jk.fr.eu.org>
http://jk.fr.eu.org

Index: partman-basicfilesystems/debian/changelog
===================================================================
--- partman-basicfilesystems/debian/changelog	(revision 63538)
+++ partman-basicfilesystems/debian/changelog	(working copy)
@@ -7,8 +7,14 @@
   * Remove no longer needed Lintian override for missing Standards-
     Version field.
 
- -- Colin Watson <cjwatson@debian.org>  Thu, 27 Aug 2009 10:58:41 +0100
+  [ Jeremie Koenig ]
+  * Hurd support (closes: <please fill in>):
+    - disable errors=remount-ro, which is not supported;
+    - force 4k blocks and 128 bytes inodes on mkfs.ext2;
+    - mark ext2 and vfat as available and skip tests for kernel modules.
 
+ -- Jeremie Koenig <jk@jk.fr.eu.org>  Wed, 23 Jun 2010 07:00:23 +0200
+
 partman-basicfilesystems (63) unstable; urgency=low
 
   [ Christian Perrier ]
Index: partman-basicfilesystems/commit.d/format_basicfilesystems
===================================================================
--- partman-basicfilesystems/commit.d/format_basicfilesystems	(revision 63538)
+++ partman-basicfilesystems/commit.d/format_basicfilesystems	(working copy)
@@ -48,7 +48,14 @@
 			db_subst $template DEVICE $(humandev $(cat device))
 			case $filesystem in
 			    ext2)
-				if [ ! -f $id/usage ]; then
+				options=''
+				if [ -f $id/usage ]; then
+					options="$options -T $(cat $id/usage)"
+				fi
+				if [ "$(udpkg --print-os)" = hurd ]; then
+					options="$options -b 4096 -I 128 -o hurd"
+				fi
+				if [ -z "$options" ]; then
 					name_progress_bar $template
 					open_dialog CREATE_FILE_SYSTEM $id $filesystem
 					read_line status
@@ -61,12 +68,8 @@
 					db_progress START 0 3 partman/text/formatting
 					db_progress INFO $template
 					db_progress SET 1
-					usage=''
-					if [ -f $id/usage ]; then
-						usage="-T $(cat $id/usage)"
-					fi
 					if log-output -t partman --pass-stdout \
-					   mkfs.ext2 $device $usage >/dev/null; then
+					   mkfs.ext2 $device $options >/dev/null; then
 						sync
 						status=OK
 					else
Index: partman-basicfilesystems/fstab.d/basic
===================================================================
--- partman-basicfilesystems/fstab.d/basic	(revision 63538)
+++ partman-basicfilesystems/fstab.d/basic	(working copy)
@@ -39,7 +39,9 @@
 			fi
 			options=$(get_mountoptions $dev $id)
 			if [ "$mountpoint" = / ]; then
-				if [ "$options" = defaults ]; then
+				if [ "$(udpkg --print-os)" = hurd ]; then
+					: # remount-ro not supported
+				elif [ "$options" = defaults ]; then
 					options="errors=remount-ro"
 				else
 					options="${options},errors=remount-ro"
Index: partman-basicfilesystems/init.d/kernelmodules_basicfilesystems
===================================================================
--- partman-basicfilesystems/init.d/kernelmodules_basicfilesystems	(revision 63538)
+++ partman-basicfilesystems/init.d/kernelmodules_basicfilesystems	(working copy)
@@ -2,6 +2,13 @@
 
 mkdir -p /var/lib/partman
 
+# On Hurd they are always available
+if [ "$(udpkg --print-os)" = hurd ]; then
+	>/var/lib/partman/ext2
+	>/var/lib/partman/vfat
+	exit 0
+fi
+
 cat /proc/modules |
 while read module_name x; do
 	if [ "$module_name" = ext2 ]; then

--- End Message ---
--- Begin Message --- 
Source: partman-basicfilesystems
Source-Version: 65

We believe that the bug you reported is fixed in the latest version of
partman-basicfilesystems, which is due to be installed in the Debian FTP archive:

partman-basicfilesystems_65.dsc
  to main/p/partman-basicfilesystems/partman-basicfilesystems_65.dsc
partman-basicfilesystems_65.tar.gz
  to main/p/partman-basicfilesystems/partman-basicfilesystems_65.tar.gz
partman-basicfilesystems_65_all.udeb
  to main/p/partman-basicfilesystems/partman-basicfilesystems_65_all.udeb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 586871@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Aurelien Jarno <aurel32@debian.org> (supplier of updated partman-basicfilesystems package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 18 Aug 2010 15:56:17 +0200
Source: partman-basicfilesystems
Binary: partman-basicfilesystems
Architecture: source all
Version: 65
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Aurelien Jarno <aurel32@debian.org>
Description: 
 partman-basicfilesystems - Add to partman support for ext2, linux-swap, fat16 and fat32 (udeb)
Closes: 586871
Changes: 
 partman-basicfilesystems (65) unstable; urgency=low
 .
   [ Colin Watson ]
   * Use 'dh $@ --options' rather than 'dh --options $@', for
     forward-compatibility with debhelper v8.
 .
   [ Jeremie Koenig ]
   * Hurd support (closes: Bug#586871):
     - disable errors=remount-ro, which is not supported;
     - force 4k blocks and 128 bytes inodes on mkfs.ext2;
     - mark ext2 and vfat as available and skip tests for kernel modules.
 .
   [ Aurelien Jarno ]
   * Add a way to override mountoptions depending on the OS.
   * GNU/kFreeBSD support:
     - Add support for module loading and detection.
     - Add kfreebsd specific mount options.
     - Add code to mount and write fstab.
 .
   [ Updated translations ]
   * Asturian (ast.po) by maacub
   * Bulgarian (bg.po) by Damyan Ivanov
   * Bosnian (bs.po) by Armin Beširović
   * Danish (da.po) by Jacob Sparre Andersen
   * Persian (fa.po) by Ebrahim Byagowi
   * Finnish (fi.po) by Esko Arajärvi
   * Panjabi (pa.po) by A S Alam
   * Telugu (te.po) by Arjuna Rao Chavala
Checksums-Sha1: 
 e5e0d9011e2a75c6391040de32f7470dd11bd88e 960 partman-basicfilesystems_65.dsc
 a77c7eecc6c0055029c95ce846cc79209e012487 173434 partman-basicfilesystems_65.tar.gz
 754f372703bfcb13bdc30d47373562c50a510fd0 140852 partman-basicfilesystems_65_all.udeb
Checksums-Sha256: 
 721cdd20cb126e717f575c8627b644eed37cd4e3508458f6dcb5bd9d928602ba 960 partman-basicfilesystems_65.dsc
 19ca83361b258e4920b9ad30216e1e3e285d38eedf0d9866cf921823e42bf7fe 173434 partman-basicfilesystems_65.tar.gz
 a5ba73611814da57b0163346260a85119978bd0b9235c47ad973720666bc48bb 140852 partman-basicfilesystems_65_all.udeb
Files: 
 c92f1eb63a4957aa319d13a9475e5ca9 960 debian-installer standard partman-basicfilesystems_65.dsc
 807c99427487c82df72a977a552a02c7 173434 debian-installer standard partman-basicfilesystems_65.tar.gz
 eadb17025c500cac755b52315c2fd7d0 140852 debian-installer standard partman-basicfilesystems_65_all.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFMa+blw3ao2vG823MRAhNhAJ4t7cfKk5cPBaQdS6DpE0pjW1AffACeJYdH
3tygvzwIT5TPsYkqimj81UU=
=sBqh
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: