[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#588776: base-installer: please don't rely on /proc/mounts, which is not available on Hurd



Package: base-installer
Version: 1.108
Tags: patch
Usertags: gsoc2010

Hello,

bootstrap-base starts by checking that something is mounted on /target,
using /proc/mounts. On Hurd, /proc/mounts does not exist, and
bootstrap-base fails as a result.

The attached patch short-circuits the /target check when /proc/mounts
does not exist.

-- 
Jeremie Koenig <jk@jk.fr.eu.org>
http://jk.fr.eu.org
Index: base-installer/debian/changelog
===================================================================
--- base-installer/debian/changelog	(revision 63843)
+++ base-installer/debian/changelog	(working copy)
@@ -1,3 +1,9 @@
+base-installer (1.109) UNRELEASED; urgency=low
+
+  * Don't check /proc/mounts if it does not exist (ie. on Hurd).
+
+ -- Jeremie Koenig <jk@jk.fr.eu.org>  Sun, 11 Jul 2010 22:36:14 +0000
+
 base-installer (1.108) unstable; urgency=low
 
   [ Martin Michlmayr ]
Index: base-installer/library.sh
===================================================================
--- base-installer/library.sh	(revision 63843)
+++ base-installer/library.sh	(working copy)
@@ -86,7 +86,8 @@
 check_target () {
 	# Make sure something is mounted on the target.
 	# Partconf causes the latter format.
-	if ! grep -q '/target ' /proc/mounts && \
+	if [ -e /proc/mounts ] && \
+	   ! grep -q '/target ' /proc/mounts && \
 	   ! grep -q '/target/ ' /proc/mounts; then
 		exit_error base-installer/no_target_mounted
 	fi

Reply to: