[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: r61376 - trunk/packages/choose-mirror



On Thu, Nov 19, 2009 at 09:46:18PM +0000, Frans Pop wrote:
> Coding style improvements for if/else statements
> [...]
> -	if (strcasecmp(protocol, "http") == 0) {
> +	if (strcasecmp(protocol, "http") == 0)
>  		return mirrors_http;
> -	}

I am still far from being a huge fan of such changes: forgetting to add
brackets back when changing the conditional block is something that
happens. And then, after loosing 30 minutes and some
head-banging-against-the-next-wall, you find yourself cursing the C
syntax… and the people who removed the brackets.

But I somehow remember that we had this discussion already…

Cheers,
-- 
Jérémy Bobbio                        .''`. 
lunar@debian.org                    : :Ⓐ  :  # apt-get install anarchism
                                    `. `'` 
                                      `-   

Attachment: signature.asc
Description: Digital signature


Reply to: