[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#536820: please add scratchbox2 variant



Hello Riku,

On Sun, Jul 19, 2009 at 5:00 PM, Riku Voipio<riku.voipio@iki.fi> wrote:
> Manpage updated. I didn't touch the whitespace issues because I already
> try match what is in the files it patch - tabs for debootstrap and functions,
> mixed for scripts/sid.
[...]

Is, it doesn't mean we ought to not avoid addming more mess on that ;-)

> Also, I think for low-volume projects such as debootstrap, it is faster to
> just fix up the whitespaces while commiting and tell the contributor
> to take a close look at whitespace issues before sending the next patch.

Well I somewhat agree with that. I've reported it to you so you could
look at it and fix it but in case you did not found the time for that
I'd do that.

BTW the thing I had noticed you got fixed.

@@ -52,6 +52,8 @@

     if doing_variant fakechroot; then
         setup_devices_fakechroot
+    elif doing_variant schratchbox; then
+        true

Typo? :-)

I'll wait few days for comments from others before commit it.

-- 
Otavio Salvador                  O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854         http://projetos.ossystems.com.br



Reply to: