tags 517644 + patch
thanks
On Mon, Mar 02, 2009 at 01:23:23PM -0300, Otavio Salvador wrote:
> > On Sunday 01 March 2009, Jérémy Bobbio wrote:
> >> I am not tagging the bug "+patch" because the problem probably needs to
> >> be solved by a different patch in Lenny and in the main branch, see
> >> below. I also lack the time to do proper testing (and also to 1prepare
> >> the needed stable updates).
> >
> > I'm not sure this is the preferred patch. Maybe we should have a patch
> > instead that only accepts oldstale if it matches the requested suite
> > (i.e. instead of making it a generally accepted value).
>
> Yes; I agree with that and it also avoids the translation issue.
>
> Even for sid I belive it should be an "exception", not a generally
> accepted value.
Attached is a patch that implements this. No thorough tests, but
"etch-support" was correctly selected by the installer.
If someone else can confirm that this works, it would be good to have it
in r1, IMHO. It'll be hard for me to find the time to properly prepare
an upload though, so please step up if you can.
Cheers,
--
Jérémy Bobbio .''`.
lunar@debian.org : :Ⓐ : # apt-get install anarchism
`. `'`
`-
diff -Nru choose-mirror-2.28lenny1/choose-mirror.c choose-mirror-2.28lenny2/choose-mirror.c
--- choose-mirror-2.28lenny1/choose-mirror.c 2008-10-27 12:32:03.000000000 +0100
+++ choose-mirror-2.28lenny2/choose-mirror.c 2009-04-04 11:37:46.000000000 +0200
@@ -320,6 +320,11 @@
}
static int choose_suite(void) {
+ /* Skip question if installation of oldstable has been preseeded. */
+ debconf_get(debconf, DEBCONF_BASE "suite");
+ if (strcmp(debconf->value, "oldstable") == 0) {
+ return 0;
+ }
/* If the base system can be installed from CD, don't allow to
* select a different suite
*/
diff -Nru choose-mirror-2.28lenny1/debian/changelog choose-mirror-2.28lenny2/debian/changelog
--- choose-mirror-2.28lenny1/debian/changelog 2009-01-06 19:38:45.000000000 +0100
+++ choose-mirror-2.28lenny2/debian/changelog 2009-04-04 11:08:31.000000000 +0200
@@ -1,3 +1,9 @@
+choose-mirror (2.28lenny2) UNRELEASED; urgency=low
+
+ * Accept "oldstable" as a correct preseed for mirror/suite.
+
+ -- Jérémy Bobbio <lunar@debian.org> Sat, 04 Apr 2009 11:07:57 +0200
+
choose-mirror (2.28lenny1) unstable; urgency=low
* Rebuilt using updated Mirrors.masterlist
Attachment:
signature.asc
Description: Digital signature