[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: r56960 - in trunk/packages/partman/partman-base: choose_partition/partition_tree debian



On Monday 29 December 2008, Jérémy Bobbio wrote:
> On Fri, Dec 26, 2008 at 02:19:16PM +0000, Colin Watson wrote:
> > Log:
> > Disable backup while displaying device/partition locked errors; it
> > makes no sense and it can cause us to exit without closing the FIFO
> > to parted_server (closes: #505477, LP: #274219).

> >--- trunk/packages/partman/partman-base/choose_partition/partition_tree/do_option	
(original)
> >+++ trunk/packages/partman/partman-base/choose_partition/partition_tree/do_option	Fri Dec 
26 14:19:16 2008
> >@@ -18,7 +18,9 @@ 
> >  	db_subst partman-base/devicelocked MESSAGE "$locked"
> >  	db_set partman-base/devicelocked false
> >  	db_input critical partman-base/devicelocked
> > -	db_go
> > +	db_capb
> > +	db_go || true
> > +	db_capb backup
>
> This should probably be "backup align" instead.  Otherwise it will
> break the columned output.

Fixed in SVN now.

Colin, this was mentioned before (<200810021640.19285.elendil@planet.nl>).

It's a bit strange to see this merged without that issue being fixed (and
to see Jérémy's message ignored/missed, although that may be due to holidays).

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: