[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#401220: exim4 auto-configuration assumes short hostnames



tags 401220 patch
user ubuntu-devel@lists.ubuntu.com
usertags 401220 ubuntu-patch intrepid
thanks

On Fri, Dec 01, 2006 at 11:40:34AM +0100, Vincent McIntyre wrote:
> Op 30-11-2006 om 15:39 schreef Vincent McIntyre:
> > Bug: exim4 auto-configuration assumes short hostnames
> > -----------------------------------------------------
> >      When prompted for the hostname by the installer I gave a 
> >      fully-qualified
> >      hostname. This was propagated to /etc/mailname without stripping the
> >      domain name, with the result that the domain name appears TWICE in
> >      /etc/mailname. That is:
> > 
> >         # cat /etc/mailname
> > 	<newhost>.<mydomain>.<mydomain>

Alain Knaff pointed out an easy fix for this in
https://bugs.launchpad.net/ubuntu/+source/netcfg/+bug/160778:

  [ Alain Knaff ]
  * If we detect that the user entered a fully-qualified domain name as the
    hostname, then remove the domain part from the hostname as well as
    copying it to netcfg/get_domain (closes: #401220).

=== modified file 'netcfg-common.c'
--- netcfg-common.c	2008-05-17 16:04:23 +0000
+++ netcfg-common.c	2008-10-13 19:42:34 +0000
@@ -637,6 +637,7 @@
             domain = strdup(s + 1);
             debconf_set(client, "netcfg/get_domain", domain);
             have_domain = 1;
+            *s = '\0';
         }
     }
     return 0;

I haven't tested this yet, but I can't find any fault in the logic.

-- 
Colin Watson                                       [cjwatson@ubuntu.com]



Reply to: