[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#497285: not possible to preseed that no gatway should be used?



On Sun, Aug 31, 2008 at 07:08:51PM +0300, Martin Michlmayr wrote:
> I think it's as simple as this.  Would this be acceptable for lenny?
> 
> Index: static.c
> ===================================================================
> --- static.c	(revision 55364)
> +++ static.c	(working copy)
> @@ -146,7 +146,8 @@
>          debconf_get(client, "netcfg/get_gateway");
>          ptr = client->value;
>          
> -        if (empty_str(ptr)) {           /* No gateway, that's fine */
> +        if (empty_str(ptr) || /* No gateway, that's fine */
> +            (strcmp(client->value, "none") == 0)) /* special case for preseeding */ {
>              /* clear existing gateway setting */
>              memset(&gateway, 0, sizeof(struct in_addr));
>              return 0;

If this makes easier to support NAS devices, I think it should go in.
Might worth another line on the preseeding appendix as well.

JFTR: "ptr" should probably be used as first argument of strcmp().

Cheers,
-- 
Jérémy Bobbio                        .''`. 
lunar@debian.org                    : :Ⓐ  :  # apt-get install anarchism
                                    `. `'` 
                                      `-   

Attachment: signature.asc
Description: Digital signature


Reply to: