Re: RFC: Output files for netboot-xen flavour
On Tue, 2008-07-22 at 11:05 +0200, Bastian Blank wrote:
> On Tue, Jul 22, 2008 at 08:42:33AM +0100, Ian Campbell wrote:
> > +# install-installer: where to obtain the Debian Installer bits, by
> > +# default these are located under install-mirror. To use a nightly
> > +# snapshot: http://people.debian.org/~joeyh/d-i/images/daily/
>
> How do you check the integrity of this files?
They aren't there yet since it isn't enabled in the build until the
686-bigmem udeb's go through NEW queue. This is one of the URLs I was
talking about when I said they were subject to finalisation.
If the issue is pointing people to daily snapshots in this way I'll
remove the example.
>
> > +disk = [ 'phy:hda1,hda1,w' ]
>
> hdXY will not work with new kernels.
Indeed, I will make this change and add a comment about xvd being
required.
Thanks for your review of my python, it's not my strongest point (as I'm
sure you can tell!). I'll only quote the bits I have a query about, for
the rest I'll make the changes you suggest.
>
> > +global var_check_boot_with_default
>
> Where did you read this?
It solved an error where the lambdas couldn't see the symbol. I notice
now that I typo'd it (boot/bool) so maybe I somehow solved it a
different way without knowing -- I'll check it out.
> > +xm_vars.var('install', use='Install Debian, default: false',
> > + check=lambda var, val: var_check_bool_with_default(False, var, val))
>
> A reason why you don't use something like this?
>
> | def check_bool(name, value):
> | value = str(value).lower()
> | if value in ('t', 'tr', 'tru', 'true')
> | return True
> | return False
> |
> | xm_vars.var('install', 'Install Debian, default: false', check_bool)
Much better than my version. The only reason to use the lambda was that
I was doing it for all the others and copied the pattern.
> | if xm_vars.env.get('install'):
> | pass
What is this bit for?
> There are some more style things ...
Thanks for your review!
Ian.
--
Ian Campbell
Current Noise: Metallica - The Outlaw Torn
He who laughs, lasts.
Reply to: