[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCHES] 686-bigmem/Xen enabled netboot images



On Sun, 2008-07-13 at 18:51 +0200, Frans Pop wrote:
> On Sunday 13 July 2008, Ian Campbell wrote:
> > > > What about retasking the new virtio udebs into virtuali{s,z}ion (or
> > > > just virt) and adding them there?
> > >
> > > That could work, but I suspect it could result in a dependency mess.
> > > You can either check /lib/modules/<ver>/modules.dep to see how bad it
> > > is or just try it. If these modules do not depend on anything much
> > > then this could be a good option.
> >
> > The xen-{blk,net}front.ko modules currently don't depend on any others
> > so it should be fairly clean. What do you think?
> 
> I think the patch you have now is fine and this option has my vote. It is 
> IMO by far the simplest solution. As the modules don't exist for the 486 
> flavor, it does not add any overhead for regular images.

Agreed. I'll stick with this then.

> > I guess I'd need to add this udeb to the pkglist for the i386 netboot.
> 
> Why would we add it to the normal netboot? Is it going to be used there?
> If not, we don't want to do that. Instead we should create a "subclass" in 
> pkg-lists and then set that "subclass" as TYPE in the config, comparable 
> to what has been done for the gtk variant of netboot.

I only wanted it for netboot-xen but I didn't know there was a mechanism
for doing that -- this subclass stuff sounds like the way (except, as
discussed above, we aren't going down this route at all).

> > The kernel-wedge patch is now trivial as mentioned above. I've included
> > the base-installer (on top of #490542, called bigmem.patch) and
> > linux-kernel-di...patch and the main installer.patch again.
> 
> I've not had any feedback on my patch yet. I'll try pinging a few people 
> on Monday, but I won't delay much longer.

Thanks.

> As far as I'm concerned you can start committing the changes, but you 
> should probably allow a few days for feedback from others.

Sure thing, I'm waiting on your patch anyway so that should give people
plenty of time.

Ian.

-- 
Ian Campbell

Uh-oh -- WHY am I suddenly thinking of a VENERABLE religious leader
frolicking on a FORT LAUDERDALE weekend?


Reply to: