[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] cdebconf: Fix build of ncurses,bogl,slang frontends



Hi Jérémy,

On Mon, May 05, 2008 at 10:15:15PM +0200, Jérémy Bobbio wrote:
> On Sun, May 04, 2008 at 03:25:47PM +0200, Max Vozeler wrote:
> > They need to be adapted to the changed API for q_get_* etc. 
> > 
> > The attached patch should be obviously correct and safe to apply,
> > but I'm sending it here for review just in case.
> 
> Well… It's been quite some time that I wonder if we should keep this
> outdated and unused frontend in cdebconf source.  If we remove them from
> the tree, they could still be resurected from the subversion history.

Whether to keep them - I have no strong opinion. 

I noticed because they are enabled by default if you don't
set the frontends explicitly (./configure; make) and those
API changes broke the build.

If noone objects, let's make them able to build again and
take the question whether to keep them separately.

> Can anyone see any reasons to actually keep them?

They may serve as interesting example code?
For one thing, they are much smaller than the other
frontends, although they may just be incomplete.

Are they already outdated and broken? Do they present
actual maintainance burden? 

If we do remove them now and keep changing the API, it 
will be significantly more difficult to ressurrect them 
later than if we just drag them along.

Just thinking aloud, since I'm not actually doing any
work on cdebconf ...

	Max


Reply to: