Bug#478591: cdebconf-entropy: Dialog texts and buttons
On Sunday 04 May 2008, Max Vozeler wrote:
> On Sat, May 03, 2008 at 10:45:22PM +0200, Frans Pop wrote:
> > On Saturday 03 May 2008, Max Vozeler wrote:
> > > How do we go about changing the string? Should we ask for review
> > > from -l10n-english first?
> >
> > IMO not needed. It would be good to post the patch to the BR first for
> > review though.
>
> Patch attached - Review is much appreciated :-)
Hmm. Should the string not also be changed in the templates and .c code of
cdebconf-entropy for all frontends?
String itself is fine by me.
Also, that does not cover the other suggestion I had for a string change. We
should probably do both at the same time.
! I also suggest changing:
! Enter random characters or move mouse randomly
! to:
! Enter random characters or make random movements with your mouse
This one probably needs changing twice: once for the title and once in the
longer description.
Maybe:
Template: debconf/entropy/gtk/action
Type: text
# :sl3:
-_Description: Enter random characters or move mouse randomly
+_Description: Enter random characters or make random mouse movements
Template: debconf/entropy/gtk/help
Type: text
# :sl3:
-_Description: You can help speed up the process by entering random
-characters on the keyboard or by moving the mouse randomly, or just wait
-until enough key data has been collected (which can take a long time).
+_Description: You can help speed up the process by entering random
+characters on the keyboard or by making random movements with the mouse,
+or just wait until enough key data has been collected (which can take a
+long time).
And today I noticed something else. When no action is taken (keyboard or
mouse) no entropy is gathered _at all_. So the last part of the sentence
above (or just wait ...) is IMO not correct.
IIRC the kernel was changed not too long ago to use less sources for entropy
and in particular no longer uses network interrupts [1].
This of course also affects the templates for the other frontends.
[1] http://lwn.net/Articles/182495/ "On the safety of Linux random numbers"
Reply to: