On Saturday 01 March 2008, Otavio Salvador wrote: > +# Check if a specific script should be used > +db_get base-installer/debootstrap_script > +DEBOOTSTRAP_SCRIPT="$RET" || true What's the point of the || true here? IMO the patch should test that the script exists and, if not, log the fact and either fail or unset the variable (maybe unless debootstrap itself already handles that case?). > + * Add facility to use a specific script by preseeding > + base-installer/script. That's a very interesting feature for Custom > + Debian Distributions and derivatives. The last sentence is a rather empty comment and should IMO be omitted.
Attachment:
signature.asc
Description: This is a digitally signed message part.