[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Fwd: Bug#446994: partman-base: <go back> from first dialog no longer works



On Wednesday 14 November 2007, anton@lml.bas.bg wrote:
> The fact I put a comment here means I have caused this bug intentionaly.
> However now I can not remember my reasons so maybe it is just a mistake.
>
> Try not to change $code from 255 to 99 here and hopefuly this will fix
> the bug. That is, remove the "if [ $code -eq 255 ]; then" line and the
> two lines after it.

Sorry Anton, but it does not work that way.

The old code was perfectly fine. You decided that it needed reorganization, 
which is fine with me. That reorganization caused a regression. Normally 
that means that its *your* responsibility to fix such regressions when they 
are reported. Pointing to others and say "try this, maybe it will fix my 
mistake" is shifting your responsibility to others, which is not very nice.

The old behavior was:
- if that dialog is displayed when partman is first started and <go back> is
  selected, exit to the menu
- if that dialog is displayed after selecting "Guided partitioning" from the
  main partman screen and <go back> is selected, return to the main partman
  screen

Please fix your changes so that the old behavior is restored and commit 
them.

Thanks,
Frans

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: