[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#440301: iso-scan.postinst fails to find ISO on partitioned USB stick



(Some replies failed to make the list because they were sent to Bug#-quiet)

Otavio Salvador <otavio@debian.org> wrote:
> Sam Couter <sam@couter.id.au> writes:
> > Otavio Salvador <otavio@debian.org> wrote:
> >> Please attach the output of:
> >>
> >> udevinfo -q env -p /block/<your usb device>
> >
> > Attached.
>
> Please, check if using this patch output your device is outputed when
> calling with partition:
>
>  ./list-devices partition
>
> diff --git a/packages/debian-installer-utils/list-devices
> b/packages/debian-installer-utils/list-devices index 1d0515c..2f52c46
> 100755
> --- a/packages/debian-installer-utils/list-devices
> +++ b/packages/debian-installer-utils/list-devices
> @@ -27,6 +27,7 @@ case $TYPE in
>                 syspaths="${syspaths:+$syspaths }$x"
>         done
>         TYPE=disk
> +       scan_partition=true
>         ;;
>      *)
>         for x in /sys/block/*; do
> @@ -50,7 +51,7 @@ for x in $syspaths; do
>         esac
>         # Some USB sticks and CD drives are misdetected as floppy
>         # This allows to scan for those
> -       if ! $match && [ "$TYPE" = maybe-usb-floppy ]; then
> +       if ! $match && ( $scan_partition || [ "$TYPE" = maybe-usb-floppy
> ] ); then if udevinfo -q env -p "$devpath" 2>/dev/null | \ grep -q
> '^ID_BUS=usb' && \
>                    udevinfo -q env -p "$devpath" 2>/dev/null | \

This patch seems bogus as ./iso-scan/debian/iso-scan.postinst already has:
111: DEVS="$(list-devices disk; list-devices partition; list-devices 
maybe-usb-floppy)"

So it *already should get this case* from explicitly using maybe-usb-floppy.
What this patch does do, is potentially changing the behavior of the 
rescue-mode postinst.

Cheers,
FJP

P.S. It does look like there is a minor bug in isoscan (which should not 
affect this case though). The first call in line 111 uses quotes, the 
second one in line 166 does not; I think this will make the comparison in 
line 167 always false (if there are multiple DEVS). I've fixed that.

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: