Hi!
Attached is a patch that will remove bashisms in the massbuild script.
This script is used to automatically create the udebs from kernel
packages.
With the attached set of changes, the enter key is required on top of
pressing "y" to confirm the build. On the other hand, the script could
also be set to explicitely use bash.
I don't have a huge personal preference, although I like the idea of
having POSIX compliant shell scripts. If there's no opposition, I'll
commit it in a few days.
Cheers,
--
Jérémy Bobbio .''`.
lunar@debian.org : :Ⓐ : # apt-get install anarchism
`. `'`
`-
Index: packages/kernel/massbuild
===================================================================
--- packages/kernel/massbuild (revision 49043)
+++ packages/kernel/massbuild (working copy)
@@ -275,6 +275,8 @@
clean_arch_tmp
exit 1
fi
+
+ BDEP_SOURCE_PREFIX=$(echo "$BDEP_SOURCE" | head -c 1)
}
retrieve_package() {
@@ -303,10 +305,10 @@
fi
;;
local)
- url="$LMIRROR/pool/main/${BDEP_SOURCE:0:1}/$BDEP_SOURCE"
+ url="$LMIRROR/pool/main/${BDEP_SOURCE_PREFIX}/$BDEP_SOURCE"
;;
pool)
- url="$MIRROR/pool/main/${BDEP_SOURCE:0:1}/$BDEP_SOURCE"
+ url="$MIRROR/pool/main/${BDEP_SOURCE_PREFIX}/$BDEP_SOURCE"
;;
incoming)
url="$INCOMING"
@@ -464,7 +466,7 @@
release manager.
EOF
fi
-read -n 1 -s -p "Do you wish to continue [yN]? " reply
+read -p "Do you wish to continue [yN]? " reply
echo
if [ "$reply" != y ] && [ "$reply" != Y ]; then
exit 0
Attachment:
signature.asc
Description: Digital signature