[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#433579: partman-dmraid: Error in logic determining if dmraid is supported



Package: partman-dmraid
Version: 1
Severity: important

On some systems, dmraid -s -c will return "no block devices found" on 
stdout with an exit code of 0, and not "No RAID disks". This was seen on 
a system with cciss, so this is likely a condition that is hit before 
the "No RAID disks" condition (something like "no suitable controller 
detected").

Result of this issues is that incorrect paths are taken (as if dmraid 
devices were detected). It would be nice if dmraid would return a 
non-zero error code in those cases instead having to parse the output of 
the command...

This also affects:
- base-installer
- hw-detect
- partman-base
- grub-installer

One solution could be to run something like (assuming that no "%" would be 
used in error messages):
   dmraid -s -c r,t --sep "%" | grep "%" | cut -d% -f1
Command needs checking!

Note that we should also test for the exit code as dmraid _can_ exit 
non-zero! Example with /sys not mounted (the errors go to stderr!):
# dmraid -s
ERROR: opening path /sys/block
ERROR: failed to discover devices
# echo $?
1

Attachment: pgpSwgg1hsjVe.pgp
Description: PGP signature


Reply to: