Re: [PATCH] partman mount.d scripts and mount options
On Mon, Jul 02, 2007 at 08:13:13PM +0200, Frans Pop wrote:
> On Monday 02 July 2007 19:43, Colin Watson wrote:
> > I can't think of any other flags that might be harmful during
> > installation. What do folks think about the attached patch?
>
> Couldn't a bad 'noexec' break the install for chrooted commands?
> Don't see any other issues.
Yes, though in that case the install would surely break as soon as you
rebooted anyway, so it seems that it's better to find out earlier.
> One question though...
> Where do the opening brackets in the case statement suddenly come from?
> I don't remember ever seeing the before; had to check the docs to see if
> it had any special meaning :-)
You need them if you have a case statement inside $(...) as otherwise
bash (though not busybox sh) will misparse the closing parenthesis in
the first case item as closing the command substitution. See also the
changelog for partman-target 41.
--
Colin Watson [cjwatson@debian.org]
Reply to: