[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: CCISS patch test



On Thu, May 24, 2007 at 06:05:09PM +0200, Robert Millan wrote:
> On Thu, May 24, 2007 at 04:09:41PM +0200, Frans Pop wrote:
> > On Wednesday 23 May 2007 18:14, Robert Millan wrote:
> > > Would someone be so kind to test the attached patch on a machine with:
> > >
> > >   - CCISS storage
> > >   - GPT partition table layout in main partition
> > >
> > > and report if d-i properly switches to grub2 because of the gpt?
> > 
> > +       /dev/cciss)
> > +               disc_offered_devfs=$(find $prefix -follow ! -name \*p[0-9] | head -n 1)
> > +       ;;
> > 
> > AFAIK /dev/cciss devices are "real" devices and not symlinks, so the code
> > should be more like the case for /dev/[hs]d[a-z] than what you have in this
> > patch.
> 
> Ok.  Please have a look at this one, which still allows for extending the check
> by simply adding more paths in the case/esac match.

Any news on this?   Any objection if I commit it?  Maybe someone will test
it on CCISS once it hits sid.

> Index: grub-installer
> ===================================================================
> --- grub-installer	(revision 46926)
> +++ grub-installer	(working copy)
> @@ -238,6 +238,9 @@
>  	/dev/[hs]d[a-z])
>  		disc_offered_devfs="$prefix"
>  	;;
> +	/dev/cciss)
> +		disc_offered_devfs=$(echo "$bootfs" | sed 's/p[0-9]\+$//')
> +	;;
>  	*)
>  		disc_offered_devfs=$(find $prefix -follow -name disc | head -n 1)
>  	;;


-- 
Robert Millan

My spam trap is honeypot@aybabtu.com.  Note: this address is only intended
for spam harvesters.  Writing to it will get you added to my black list.



Reply to: