Bug#397973: parted: Fix mac partition table corruption
A further concern on this patch:
On Sat, Mar 03, 2007 at 02:47:04AM +0100, David Härdeman wrote:
> diff -ur ./parted-1.7.1.orig/libparted/labels/mac.c ./parted-1.7.1/libparted/labels/mac.c
> --- ./parted-1.7.1.orig/libparted/labels/mac.c 2006-05-25 19:28:55.000000000 +0200
> +++ ./parted-1.7.1/libparted/labels/mac.c 2007-03-03 02:41:42.000000000 +0100
> @@ -1260,19 +1260,23 @@
> return 1;
>
> case PED_PARTITION_LVM:
> - mac_data->is_lvm = state;
> - if (state)
> + if (state) {
> strcpy (mac_data->system_name, "Linux_LVM");
> - else
> - mac_partition_set_system (part, part->fs_type);
> + mac_data->is_lvm = state;
> + } else {
> + if (mac_data->is_lvm)
> + mac_partition_set_system (part, part->fs_type);
> + }
> return 1;
So in this case, if (!state), mac_data->is_lvm is never un-set. Is that not
an issue?
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
vorlon@debian.org http://www.debian.org/
Reply to: