[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#377391: marked as done (Extremely irritating libparted error message during LVM on RAID setup)

Your message dated Sun, 09 Jul 2006 09:02:08 -0700
with message-id <E1FzbjU-0006SX-T3@spohr.debian.org>
and subject line Bug#377391: fixed in partman-lvm 41
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message --- 
Package: partman-lvm
Version: 41
Severity: important
Tags: patch, pending

After a RAID device has been set up and that device has been selected "for 
use with LVM", the following message is displayed when changes to devices 
and partitions are committed to disk before configuring LVM:
   "Error informing the kernel about modifications to partition
    /dev/md/0p1 -- Invalid argument.  This means Linux won't know about
    any changes you made to /dev/md/0p1 until you reboot -- so you
    shouldn't mount it or use it in any way before rebooting."

For Sarge installations a different, but similar message was shown:
   "The kernel was unable to re-read the partition table on /dev/md/0
    (Invalid argument).  This means Linux won't know anything nothing
    about the modifications you made until you reboot.  You should reboot
    your computer before doing anything with /dev/md/0."

The basic cause is that partitions on a software RAID device are not 
really supported by parted. I did some tests using parted from shell with 
very inconsistent results (changes are sometimes committed, but 'parted 
print' does not show them while 'fdisk list' does; kernel/udev does not 
create /dev/md/0p1 device nodes).

After investigation the only reason partman tries to commit changes at all 
turned out to be that the script update.d/21lvm_sync_flag sets the "lvm" 
flag for a "dummy" partition that is created by partman in 
init.d/31md-devices.

Earlier hacks in partman-lvm have already made sure that partman itself 
does not rely only on the flag, but sets "method" instead (based on the 
output of 'pvdisplay') in case of LVM on RAID. In line with this and as 
the flag is never actually written anyway, it seems safe not to try 
setting the flag if the lvm device is on a /dev/md/X device.

The following patch implements this.
--- update.d/lvm_sync_flag      (revision 38772)
+++ update.d/lvm_sync_flag      (working copy)
@@ -24,6 +24,16 @@
        method=$(cat $id/method)
 fi

+# As setting flags on RAID devices does not work and causes errors from
+# libparted, do not attempt to sync flags in case of LVM on RAID.
+# This is in line with the hacks in init.d/lvm and undo.d/lvm.
+if [ -f device ]; then
+       case $(cat device) in
+           /dev/md/*)
+               exit 0 ;;
+       esac
+fi
+
 has_lvm=no
 flags=''
 open_dialog GET_FLAGS $id

Attachment: pgpetyV62eSHW.pgp
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: partman-lvm
Source-Version: 41

We believe that the bug you reported is fixed in the latest version of
partman-lvm, which is due to be installed in the Debian FTP archive:

partman-lvm_41.dsc
  to pool/main/p/partman-lvm/partman-lvm_41.dsc
partman-lvm_41.tar.gz
  to pool/main/p/partman-lvm/partman-lvm_41.tar.gz
partman-lvm_41_all.udeb
  to pool/main/p/partman-lvm/partman-lvm_41_all.udeb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 377391@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Frans Pop <fjp@debian.org> (supplier of updated partman-lvm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun,  9 Jul 2006 17:48:12 +0200
Source: partman-lvm
Binary: partman-lvm
Architecture: source all
Version: 41
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Frans Pop <fjp@debian.org>
Description: 
 partman-lvm - Adds support for LVM to partman (udeb)
Closes: 329765 377391
Changes: 
 partman-lvm (41) unstable; urgency=low
 .
   [ David Härdeman ]
   * Remove parted_names since its of no use for virtual filesystems
     (closes: #329765)
 .
   [ Frans Pop ]
   * Major whitespace cleanup in scripts + some minor syntax changes.
   * Sync undo.d/lvm script with init.d/lvm; adds missing hack for RAID devices.
   * As setting flags on RAID devices does not work and causes errors from
     libparted, do not attempt to sync flags in case of LVM on RAID. Partman
     itself does not rely on the lvm flag, but uses the "method" instead.
     This is in line with existing hacks in init.d/lvm and undo.d/lvm.
     Closes: #377391.
   * Remove duplicate depends; add debconf dependency.
 .
   [ Updated translations ]
   * Arabic (ar.po) by Ossama M. Khayat
   * Czech (cs.po) by Miroslav Kure
   * Dzongkha (dz.po) by Jurmey Rabgay
   * Japanese (ja.po) by Kenshi Muto
   * Macedonian (mk.po) by Georgi Stanojevski
   * Swedish (sv.po) by Daniel Nylander
Files: 
 cccd878814cf8491b1f343befb6e40d0 625 debian-installer standard partman-lvm_41.dsc
 2891ba62f507c4f045e1a73eddd745df 160141 debian-installer standard partman-lvm_41.tar.gz
 afd885adc6bf5a86e76d31cad79e0231 157936 debian-installer standard partman-lvm_41_all.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFEsSdLgm/Kwh6ICoQRAqN4AJ4s9fCfdKXgmTid6MgQX0c9YN6BzwCg2QlU
qrSpqMYyiIaBG4V2P9ptG4k=
=RepX
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: