[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#355804: Proposed patch



Frans Pop wrote:
On Wednesday 08 March 2006 16:26, fiandro@tiscali.it wrote:

on the cutted text bug, as i said before, this is a GTKDFB (all
versions) upstream bug


There are _two_ issues with the info text:
1. the text is cut off
2. it is not displayed at all when install is running automated

For 1, that is upstream, OK.

For 2, see the first screenshot: the infotext is not displayed there and while it should be. This is the same as with the buttons: it needs to be refreshed not only when the user is asked for input.

As in the NEWT frontend happens, obj->info is displayed only if it's not NULL: this check (and final displaying, if that's the case) is triggered by the "expose_event" event sent to the widget containing the banner. As we have no WM system, such expose_event is currently triggered by gtk_go() and gtk_progress_start() only: when a progressbar is started, even if previously no questions were asked, for sure gtk_progress_started() is called, so i wonder why obj->info is not rendered at all. Assuming the rendering mechanism is correct, i suppose that obj->info is set AFTER gtk_progress_start() is called and before the gtk_go() call. By the way, today i noticed the mechanism that renders the obj->info message doesn't render the text in a clean way in some circumstances, but "overwrites" old text if this has changed -> for sure some work has to be done here. As the button problem is a distinct bug i'll start committing the patch and later i'll try to fix the obj->info bug.

ciao

Attilio



Reply to: