Re: [g-i] fonts: a few thoughts
On 2/1/06, Frans Pop <aragorn@tiscali.nl> wrote:
> > I have added the shift for now, but I think your patch is not very nice
> >
> > It searches the whole parameter string for the presence of the option,
> > but using a 'shift' if the parameter is present assumes that it is the
> > first parameter. This could lead to another parameter being removed
> > instead and maybe to the script failing.
> >
> > Is a better solution for checking the presence of the parameter
> > possible?
>
> I never saw a reply to this. I still don't like this solution in the
> script and as the original scripts _was_ clean, I plan to revert the the
> change if this is not corrected.
Your previous statement is incorrect, AFAICT, "if (Strstr($1,
"--invert") != -1)" tests _first_ parameter to contain "--invert".
FWIW the only bad thing is the fact that if someone puts there
"a--invert" then it will also invert the thing. This is the only
asumption, that the user will mean --invert when he/she writes
<whatever--invertwhatever>. I can change this to be more thorough, but
I can't find the link to the scripting page that Davide gave to me in
Spain.
I will fix this, but I can't find the scripts page on fontforge.
Davide? (maybe adding the link on the wiki would be a good idea).
[PATCH] As a side note, at line 87 "endif" is needed. I found this a
couple days ago, but i forgot to report it (although I fixed it on my
machine).
--
Regards,
EddyP
=============================================
"Imagination is more important than knowledge" A.Einstein
Reply to: