Bug#330418: marked as done (cdebconf: white-on-black theme)
Your message dated Mon, 30 Jan 2006 02:32:09 -0800
with message-id <E1F3WKP-0005i9-CK@spohr.debian.org>
and subject line Bug#330418: fixed in cdebconf 0.96
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 27 Sep 2005 22:23:16 +0000
>From barbier@mp4h.org Tue Sep 27 15:23:16 2005
Return-path: <barbier@mp4h.org>
Received: from main.uucpssh.org [212.27.33.224]
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1EKNr2-0004Eu-00; Tue, 27 Sep 2005 15:23:16 -0700
Received: from localhost (localhost [127.0.0.1])
by main.uucpssh.org (Postfix) with ESMTP id D889C8A985;
Wed, 28 Sep 2005 00:23:09 +0200 (CEST)
Received: by main.uucpssh.org (Postfix, from userid 10)
id 6566D8C4DA; Wed, 28 Sep 2005 00:23:09 +0200 (CEST)
Received: by localhost.localdomain (Postfix, from userid 1000)
id 9188747B5B; Wed, 28 Sep 2005 00:10:39 +0200 (CEST)
Date: Wed, 28 Sep 2005 00:10:39 +0200
From: Denis Barbier <barbier@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: cdebconf: white-on-black theme
Message-ID: <20050927221039.GA17518@linuxfr.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="cNdxnHkX5QqsyA0e"
Content-Disposition: inline
X-Reportbug-Version: 3.17
User-Agent: Mutt/1.5.10i
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
--cNdxnHkX5QqsyA0e
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Package: cdebconf
Severity: normal
Tags: patch
Hi,
the attached patch changes colors in the newt frontend when
bg=dark is entered on command-line prompt, to provide a
white-on-black theme. This is an accessibility issue, some
people can hardly read on a white background.
Ok to commit?
Denis
--cNdxnHkX5QqsyA0e
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="dark.patch"
Index: debian/changelog
===================================================================
--- debian/changelog (revision 31022)
+++ debian/changelog (working copy)
@@ -1,9 +1,15 @@
cdebconf (0.88) UNRELEASED; urgency=low
+ [ Colin Watson ]
* Remove hardcoded limit on length of DATA commands.
- -- Colin Watson <cjwatson@debian.org> Mon, 26 Sep 2005 15:15:43 +0100
+ [ Denis Barbier ]
+ * Change colors in the newt frontend to have a black background if the
+ bg environment variable is set to "dark". Some people can hardly
+ read on a white background.
+ -- Denis Barbier <barbier@debian.org> Tue, 27 Sep 2005 23:20:07 +0200
+
cdebconf (0.87) unstable; urgency=low
[ Attilio Fiandrotti ]
Index: src/modules/frontend/newt/newt.c
===================================================================
--- src/modules/frontend/newt/newt.c (revision 31022)
+++ src/modules/frontend/newt/newt.c (working copy)
@@ -72,6 +72,41 @@
int scale_textbox_height;
};
+struct newtColors newtAltColorPalette = {
+ "white", "blue", /* root fg, bg */
+ /*"black", "lightgray",*/ /* border fg, bg */
+ "white", "black", /* border fg, bg */
+ /*"black", "lightgray",*/ /* window fg, bg */
+ "white", "black", /* window fg, bg */
+ /*"white", "black",*/ /* shadow fg, bg */
+ "white", "blue", /* shadow fg, bg */
+ /*"red", "lightgray",*/ /* title fg, bg */
+ "yellow", "black", /* title fg, bg */
+ "lightgray", "red", /* button fg, bg */
+ "red", "lightgray", /* active button fg, bg */
+ "yellow", "blue", /* checkbox fg, bg */
+ "blue", "brown", /* active checkbox fg, bg */
+ "yellow", "blue", /* entry box fg, bg */
+ /*"blue", "lightgray",*/ /* label fg, bg */
+ "brightred", "black", /* label fg, bg */
+ /*"black", "lightgray",*/ /* listbox fg, bg */
+ "lightgray", "black", /* listbox fg, bg */
+ "yellow", "blue", /* active listbox fg, bg */
+ /*"black", "lightgray",*/ /* textbox fg, bg */
+ "white", "black", /* textbox fg, bg */
+ "lightgray", "black", /* active textbox fg, bg */
+ /*"white", "blue",*/ /* help line */
+ "white", "black", /* help line */
+ "yellow", "blue", /* root text */
+ "blue", /* scale full */
+ "red", /* scale empty */
+ "blue", "lightgray", /* disabled entry fg, bg */
+ /*"black", "lightgray",*/ /* compact button fg, bg */
+ "lightgray", "black", /* compact button fg, bg */
+ "yellow", "red", /* active & sel listbox */
+ "black", "brown" /* selected listbox */
+};
+
typedef int (newt_handler)(struct frontend *obj, struct question *q);
#define q_get_extended_description(q) question_get_field((q), "", "extended_description")
@@ -957,15 +992,19 @@
static int
newt_handler_error(struct frontend *obj, struct question *q)
{
- char *oldcolor;
+ char *oldrootBg, *oldshadowBg;
int ret;
- struct newtColors palette = newtDefaultColorPalette;
+ struct newtColors palette = newtAltColorPalette;
- oldcolor = palette.rootBg;
+ oldrootBg = palette.rootBg;
+ oldshadowBg = palette.shadowBg;
+ if (strcmp(oldrootBg, oldshadowBg) == 0)
+ palette.shadowBg = "red";
palette.rootBg = "red";
newtSetColors(palette);
ret = newt_handler_note(obj, q);
- palette.rootBg = oldcolor;
+ palette.rootBg = oldrootBg;
+ palette.shadowBg = oldshadowBg;
newtSetColors(palette);
return ret;
}
@@ -1001,11 +1040,16 @@
newt_initialize(struct frontend *obj, struct configuration *conf)
{
int i, width = 80, height = 24;
+ const char *palette;
obj->interactive = 1;
obj->data = calloc(1, sizeof(struct newt_data));
SLang_init_tty(0, 1, 0); /* disable flow control */
newtInit();
+ palette = getenv("bg");
+ if (palette == NULL || strcmp(palette, "dark") != 0)
+ newtAltColorPalette = newtDefaultColorPalette;
+ newtSetColors(newtAltColorPalette);
newtGetScreenSize(&width, &height);
// Fill the screen so people can shift-pgup properly
for (i = 0; i < height; i++)
@@ -1053,6 +1097,7 @@
cleared = 1;
SLang_init_tty(0, 1, 0); /* disable flow control */
newtInit();
+ newtSetColors(newtAltColorPalette);
newtCls();
}
if (obj->info != NULL) {
@@ -1112,6 +1157,7 @@
obj->progress_cur = min;
SLang_init_tty(0, 1, 0); /* disable flow control */
newtInit();
+ newtSetColors(newtAltColorPalette);
newtCls();
if (obj->info != NULL) {
char *text = q_get_description(obj->info);
--cNdxnHkX5QqsyA0e--
---------------------------------------
Received: (at 330418-close) by bugs.debian.org; 30 Jan 2006 10:40:30 +0000
>From katie@ftp-master.debian.org Mon Jan 30 02:40:30 2006
Return-path: <katie@ftp-master.debian.org>
Received: from katie by spohr.debian.org with local (Exim 4.50)
id 1F3WKP-0005i9-CK; Mon, 30 Jan 2006 02:32:09 -0800
From: Colin Watson <cjwatson@debian.org>
To: 330418-close@bugs.debian.org
X-Katie: $Revision: 1.65 $
Subject: Bug#330418: fixed in cdebconf 0.96
Message-Id: <E1F3WKP-0005i9-CK@spohr.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Mon, 30 Jan 2006 02:32:09 -0800
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
Source: cdebconf
Source-Version: 0.96
We believe that the bug you reported is fixed in the latest version of
cdebconf, which is due to be installed in the Debian FTP archive:
cdebconf-gtk-udeb_0.96_powerpc.udeb
to pool/main/c/cdebconf/cdebconf-gtk-udeb_0.96_powerpc.udeb
cdebconf-newt-udeb_0.96_powerpc.udeb
to pool/main/c/cdebconf/cdebconf-newt-udeb_0.96_powerpc.udeb
cdebconf-priority_0.96_all.udeb
to pool/main/c/cdebconf/cdebconf-priority_0.96_all.udeb
cdebconf-text-udeb_0.96_powerpc.udeb
to pool/main/c/cdebconf/cdebconf-text-udeb_0.96_powerpc.udeb
cdebconf-udeb_0.96_powerpc.udeb
to pool/main/c/cdebconf/cdebconf-udeb_0.96_powerpc.udeb
cdebconf_0.96.dsc
to pool/main/c/cdebconf/cdebconf_0.96.dsc
cdebconf_0.96.tar.gz
to pool/main/c/cdebconf/cdebconf_0.96.tar.gz
cdebconf_0.96_powerpc.deb
to pool/main/c/cdebconf/cdebconf_0.96_powerpc.deb
libdebconfclient0-dev_0.96_powerpc.deb
to pool/main/c/cdebconf/libdebconfclient0-dev_0.96_powerpc.deb
libdebconfclient0-udeb_0.96_powerpc.udeb
to pool/main/c/cdebconf/libdebconfclient0-udeb_0.96_powerpc.udeb
libdebconfclient0_0.96_powerpc.deb
to pool/main/c/cdebconf/libdebconfclient0_0.96_powerpc.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 330418@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Colin Watson <cjwatson@debian.org> (supplier of updated cdebconf package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Mon, 30 Jan 2006 09:58:17 +0000
Source: cdebconf
Binary: cdebconf-slang-udeb libdebconfclient0 cdebconf-priority cdebconf libdebconfclient0-dev cdebconf-udeb libdebconfclient0-udeb cdebconf-gtk-udeb cdebconf-text-udeb cdebconf-newt-udeb
Architecture: source powerpc all
Version: 0.96
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Colin Watson <cjwatson@debian.org>
Description:
cdebconf - Debian Configuration Management System (C-implementation)
cdebconf-gtk-udeb - Gtk+ frontend for Debian Configuration Management System (udeb)
cdebconf-newt-udeb - Newt frontend for Debian Configuration Management System (udeb)
cdebconf-priority - Change debconf priority (udeb)
cdebconf-text-udeb - Plain text frontend for Debian Configuration Management System (udeb)
cdebconf-udeb - Debian Configuration Management System (C-implementation) (udeb)
libdebconfclient0 - Debian Configuration Management System (C-implementation)
libdebconfclient0-dev - Development files for cdebconf
libdebconfclient0-udeb - Debian Configuration Management System (C-implementation) (udeb)
Closes: 330418 339379
Changes:
cdebconf (0.96) unstable; urgency=low
.
[ Frans Pop ]
* Fix crash when console is switched in gtk-frontend (closes: #339379).
Continue processing when interupt is received from DirectFB while the
read function is blocked while listening to the client.
Thanks to Denis Oliver Kropp for helping debug this issue.
.
[ Denis Barbier ]
* Change colors in the newt frontend to have a black background if the
FRONTEND_BACKGROUND environment variable is set to "dark". Some people
can hardly read on a white background (closes: #330418).
.
[ Attilio Fiandrotti ]
* GTK theme from gtkrc file is reloaded every time a question is displayed.
Minor typos were fixed.
* BG colour of questions description and extended description in the GTK
frontend is the same of the main window.
* Reorganized the GTK frontend code before switching specialized question
handlers to the plugin system.
.
[ Colin Watson ]
* Fix early return from text_progress_set, broken by progress bar
cancellation.
* Add 'cdebconf' extension to man pages to avoid clashing with
debconf-doc.
* Actually set TARGET during install target, as apparently expected by
src/Makefile.in, so that we don't try to install includes into udebs
(although luckily we failed to do so due to dh_install).
* Move cdebconf binaries to /usr/lib/cdebconf, leaving symlinks in
/usr/bin and /usr/sbin behind only in the udeb; drop
/usr/share/debconf/confmodule and /usr/share/debconf/frontend from the
deb. This renders cdebconf coinstallable with debconf, although changes
to the debconf confmodule are required to make it actually useful.
* Remove cdebconf preinst and postrm, no longer required.
* Remove dpkg-reconfigure from the udeb; d-i apparently hasn't used it
since main-menu 0.018. Saves about 4KB.
.
[ Updated translations ]
* Lithuanian (lt.po) by KÄ?stutis BiliÅ«nas
* Malagasy (mg.po) by Jaonary Rabarisoa
* Romanian (ro.po) by Eddy PetriÅ?or
* Slovenian (sl.po) by Jure Cuhalev
* Albanian (sq.po) by Elian Myftiu
* Ukrainian (uk.po) by Eugeniy Meshcheryakov
* Vietnamese (vi.po) by Clytie Siddall
Files:
cfc15769363e599fcc68fdb5dd584c1f 1171 utils optional cdebconf_0.96.dsc
fa12d0b615ae843de0c7ba4def503bc0 222373 utils optional cdebconf_0.96.tar.gz
510e84466769c3940f93e6da1a98f43c 2400 debian-installer standard cdebconf-priority_0.96_all.udeb
92913e9f7ec70a31f01a4d378182d2c8 152532 utils extra cdebconf_0.96_powerpc.deb
d6e2b6a6d61f838a2dfb952f62ab5dab 30288 libs optional libdebconfclient0_0.96_powerpc.deb
ee89899e1af744fcabbb89481cc30f12 29664 libdevel optional libdebconfclient0-dev_0.96_powerpc.deb
f982c406008163f48db6a02ec625b978 73258 debian-installer standard cdebconf-udeb_0.96_powerpc.udeb
ab10ba97c768e946c46fecd2ffafa884 4860 debian-installer optional libdebconfclient0-udeb_0.96_powerpc.udeb
ed4edc2a0d051d13ec348d5011047cfd 16500 debian-installer optional cdebconf-newt-udeb_0.96_powerpc.udeb
ef0544671ec3ff53e875b62c6f06218e 18886 debian-installer optional cdebconf-text-udeb_0.96_powerpc.udeb
79123899001c1adb81fd1b5e34122045 20326 debian-installer optional cdebconf-gtk-udeb_0.96_powerpc.udeb
Package-Type: udeb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFD3eaJ9t0zAhD6TNERAhMFAJ91tjFqWf3qRW+jYuM1385fJj4s2ACfdJid
DAXIBd09EwzbQoevQ1Lcn2k=
=fZav
-----END PGP SIGNATURE-----
Reply to: