[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#337191: marked as done (never displays useful error messages)



Your message dated Fri, 18 Nov 2005 10:17:06 -0800
with message-id <E1EdAnK-0004Jr-P1@spohr.debian.org>
and subject line Bug#337191: fixed in base-installer 1.37
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 3 Nov 2005 05:55:11 +0000
>From joey@kitenet.net Wed Nov 02 21:55:11 2005
Return-path: <joey@kitenet.net>
Received: from kitenet.net [64.62.161.42] (postfix)
	by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
	id 1EXY47-0003xf-00; Wed, 02 Nov 2005 21:55:11 -0800
Received: from dragon.kitenet.net (101-158-dial.xtn.net [66.118.101.158])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "Joey Hess", Issuer "Joey Hess" (verified OK))
	by kitenet.net (Postfix) with ESMTP id B66DF17DC7
	for <submit@bugs.debian.org>; Thu,  3 Nov 2005 05:55:08 +0000 (GMT)
Received: by dragon.kitenet.net (Postfix, from userid 1000)
	id 0DE25BEF92; Thu,  3 Nov 2005 00:55:30 -0500 (EST)
Date: Thu, 3 Nov 2005 00:55:30 -0500
From: Joey Hess <joeyh@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: never displays useful error messages
Message-ID: <[🔎] 20051103055530.GA916@kitenet.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="tThc/1wpZn/ma/RB"
Content-Disposition: inline
X-Reportbug-Version: 3.17
User-Agent: Mutt/1.5.11
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02


--tThc/1wpZn/ma/RB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Package: base-installer
Severity: normal

If debootstrap outputs this:

+ echo E: CORRUPTFILE
+ echo EA: http://ftp.us.debian.org/debian/dists/etch/main/binary-i386/Pack=
ages.gz
+ echo EF: %s was corrupt
+ exit 1

(This is just an example, and is normally a warning, not an error, but
any error would be handled the same.)

run-debootstrap does this:

Nov  3 00:36:26 frontend: --> SUBST base-installer/debootstrap/info/validat=
ing SECTION Retrieving Packages files
Nov  3 00:36:26 frontend: Adding [SECTION] -> [Retrieving Packages files]
Nov  3 00:36:26 frontend: <-- 0
Nov  3 00:36:26 frontend: --> PROGRESS INFO base-installer/debootstrap/info=
/validating
Nov  3 00:36:26 frontend: <-- 0 OK
Nov  3 00:36:26 frontend: --> SUBST base-installer/debootstrap/error-exitco=
de EXITCODE 1
Nov  3 00:36:26 frontend: Adding [EXITCODE] -> [1]
Nov  3 00:36:26 frontend: <-- 0
Nov  3 00:36:26 frontend: --> INPUT critical base-installer/debootstrap/err=
or-exitcode
Nov  3 00:36:26 frontend: <-- 0 question will be asked
Nov  3 00:36:26 frontend: --> GO

The code block to handle E: codes is not firing at all, probably=20
because the sig_child handler arrives nearly immediatly after the error tex=
t.

So for an error run-debootstrap doesn't pay any attention to the E:
codes which it could use to display a nice informative error message and
instead it just displays the nearly useless message about debootstrap
existing nonzero.

Fixing this will make it much easier to debug debootstrap problems. It
seems to me that run-debootstrap should take care to consume all of its
stdin and process it and display any appropriate messages to the user
even if it's already received a SIGCHILD. Currently it checks several
places for child_exit to be set and exits immediatly if it is.

--=20
see shy jo

--tThc/1wpZn/ma/RB
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFDaaZSd8HHehbQuO8RAgUNAJ0eSLCiSu2wFxt9KRMpiRTkP9LulACgh4bC
0zZwxHSBBt2u5lWt5/CppF0=
=a01v
-----END PGP SIGNATURE-----

--tThc/1wpZn/ma/RB--

---------------------------------------
Received: (at 337191-close) by bugs.debian.org; 18 Nov 2005 18:21:24 +0000
>From katie@ftp-master.debian.org Fri Nov 18 10:21:24 2005
Return-path: <katie@ftp-master.debian.org>
Received: from katie by spohr.debian.org with local (Exim 4.50)
	id 1EdAnK-0004Jr-P1; Fri, 18 Nov 2005 10:17:06 -0800
From: Joey Hess <joeyh@debian.org>
To: 337191-close@bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#337191: fixed in base-installer 1.37
Message-Id: <E1EdAnK-0004Jr-P1@spohr.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Fri, 18 Nov 2005 10:17:06 -0800
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02

Source: base-installer
Source-Version: 1.37

We believe that the bug you reported is fixed in the latest version of
base-installer, which is due to be installed in the Debian FTP archive:

base-installer_1.37.dsc
  to pool/main/b/base-installer/base-installer_1.37.dsc
base-installer_1.37.tar.gz
  to pool/main/b/base-installer/base-installer_1.37.tar.gz
base-installer_1.37_i386.udeb
  to pool/main/b/base-installer/base-installer_1.37_i386.udeb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 337191@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joey Hess <joeyh@debian.org> (supplier of updated base-installer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 18 Nov 2005 13:02:56 -0500
Source: base-installer
Binary: base-installer
Architecture: source i386
Version: 1.37
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Joey Hess <joeyh@debian.org>
Description: 
 base-installer - Install the base system (udeb)
Closes: 337191
Changes: 
 base-installer (1.37) unstable; urgency=low
 .
   * Remove sigchld handler in run_debootstrap. It caused it to stop processing
     before it got to debootstrap error messages, so useful error messages
     were not displayed. Closes: #337191
   * Temporarily switch back to using initrd-tools for 2.6, until
     initramfs-tools is in testing.
 .
   [ Updated translations ]
   * German (de.po) by Jens Seidel
   * French (fr.po) by Christian Perrier
   * Portuguese (Brazil) (pt_BR.po) by André Luís Lopes
Files: 
 fa83acb3fb7edef91f64d0f8dbae0ab3 805 debian-installer required base-installer_1.37.dsc
 04256fef306d442534429d7c503e8964 153975 debian-installer required base-installer_1.37.tar.gz
 eaac9f269e755f26bf612a705115aded 91694 debian-installer required base-installer_1.37_i386.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFDfhfA2tp5zXiKP0wRAjrdAJ949cTuSSKedTiEbQmj87pG9x1+fwCfVc7W
FIoH91rRshVbCQMKTA6lbgM=
=zpWI
-----END PGP SIGNATURE-----



Reply to: