Bug#306334: marked as done (kbd-chooser: Distinguish between "no keyboard" and "skip config")
Your message dated Thu, 22 Sep 2005 15:19:09 +0200
with message-id <200509221519.10362.aragorn@tiscali.nl>
and subject line Not an NMU
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 25 Apr 2005 20:33:09 +0000
>From aragorn@tiscali.nl Mon Apr 25 13:33:08 2005
Return-path: <aragorn@tiscali.nl>
Received: from smtp-out0.tiscali.nl [195.241.79.175]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DQAGS-00047Q-00; Mon, 25 Apr 2005 13:33:08 -0700
Received: from strider.fjphome.nl (195-240-184-66-mx.xdsl.tiscali.nl [195.240.184.66])
by smtp-out0.tiscali.nl (Postfix) with ESMTP id EAA2680116E2
for <submit@bugs.debian.org>; Mon, 25 Apr 2005 22:33:06 +0200 (CEST)
From: Frans Pop <aragorn@tiscali.nl>
To: submit@bugs.debian.org
Subject: kbd-chooser: Distinguish between "no keyboard" and "skip config"
Date: Mon, 25 Apr 2005 22:33:09 +0200
User-Agent: KMail/1.7.2
MIME-Version: 1.0
Content-Type: multipart/signed;
boundary="nextPart1122920.fAjIMCtDqk";
protocol="application/pgp-signature";
micalg=pgp-sha1
Content-Transfer-Encoding: 7bit
Message-Id: <200504252233.09574.aragorn@tiscali.nl>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
--nextPart1122920.fAjIMCtDqk
Content-Type: text/plain;
charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Package: kbd-chooser
Severity: wishlist
I'd like to implement the patch below to offer a little bit more flexibility
in kbd-chooser (patch not yet tested).
This bug report is mostly to get feedback on the idea. I will commit the
patch depending on comments.
Currently a "No kbd to configure" option is included on:
- an installation over serial console or UML
- if the type of keyboard (arch) could not be determined (mostly 2.4 kernels)
Actually "no keyboard" is more like "keep default kernel keymap", i.e.
"Do not configure keyboard".
Sparc issues have shown that not selecting a keymap can be a very useful
option.
The patch makes the difference between the two situations more clear and
_always_ adds the "Do not configure keyboard" option (normally only shown
at medium/low prio) for non-sercon/UML installs.
The default value for "kbd architecture" does not change from the current
situation.
kbd-chooser/no-keyboard: No keyboard to configure
kbd-chooser/skip-config: Do not configure keyboard
These templates are fairly close. In principle one could be dropped for
space considerations. My preference would be to keep the second in that case.
Cheers,
FJP
Index: kbd-chooser.c
===================================================================
--- kbd-chooser.c (revision 27033)
+++ kbd-chooser.c (working copy)
@@ -711,18 +711,16 @@
}
sercon = check_if_serial_console();
umlcon = check_if_uml_console();
- none = translated_template_get ("kbd-chooser/no-keyboard");
if (sercon == SERIAL_PRESENT || umlcon == SERIAL_PRESENT) {
+ none = translated_template_get ("kbd-chooser/no-keyboard");
choices++;
s = insert_description (s, none, &first_entry);
mydebconf_default_set ("console-tools/archs", none);
} else {
- if (((preferred == NULL) || (preferred->present == UNKNOWN))
- && (sercon != SERIAL_PRESENT) && (umlcon != SERIAL_PRESENT)) {
- di_info ("Can't tell if kbd present; add no keyboard option\n");
- choices++;
- s = insert_description (s, none, &first_entry);
- }
+ // Add option to skip keyboard configuration (use kernel keymap)
+ none = translated_template_get ("kbd-chooser/skip-config");
+ choices++;
+ s = insert_description (s, none, &first_entry);
mydebconf_default_set ("console-tools/archs",
preferred ? preferred->description : none);
}
--nextPart1122920.fAjIMCtDqk
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
iD8DBQBCbVQFgm/Kwh6ICoQRAn3gAJkB0V6FWgBl6t9/l/PVXhjxT+WoyQCfT1p5
EuYaFusNIa8Q3OhoJfn+X/Q=
=n5te
-----END PGP SIGNATURE-----
--nextPart1122920.fAjIMCtDqk--
---------------------------------------
Received: (at 306334-done) by bugs.debian.org; 22 Sep 2005 13:19:09 +0000
>From aragorn@tiscali.nl Thu Sep 22 06:19:09 2005
Return-path: <aragorn@tiscali.nl>
Received: from gauss.mathematik.uni-oldenburg.de [134.106.106.200]
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1EIQyj-0001ze-00; Thu, 22 Sep 2005 06:19:09 -0700
Received: from strider.lan (dhcp-sn38-07.hrz.uni-oldenburg.de [134.106.38.27])
by gauss.mathematik.uni-oldenburg.de (Postfix) with ESMTP id 34A6A53B54
for <306334-done@bugs.debian.org>; Thu, 22 Sep 2005 15:19:08 +0200 (CEST)
From: Frans Pop <aragorn@tiscali.nl>
To: 306334-done@bugs.debian.org
Subject: Not an NMU
Date: Thu, 22 Sep 2005 15:19:09 +0200
User-Agent: KMail/1.7.2
MIME-Version: 1.0
Content-Type: text/plain;
charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200509221519.10362.aragorn@tiscali.nl>
Delivered-To: 306334-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no
version=2.60-bugs.debian.org_2005_01_02
Upload was not intended as NMU.
Reply to: