Bug#229648: cdebconf: "seen" handling broken
On Mon, Jan 26, 2004 at 07:47:41PM +0100, Steinar H. Gunderson wrote:
> On Mon, Jan 26, 2004 at 01:46:54PM -0500, Joey Hess wrote:
> > Tollef made that change to main-menu (version 0.018), but did not say
> > why in the changelog.
>
> I've hit Tollef, but he still can't remember why. :-)
>
> However, I'm quite sure this has worked long after 0.018 -- this was correct
> the last time I looked at it, AFAIK. Is there a good reason why we just can't
> revert it? :-)
In order to save space?
With the attached patch, udpkg should work as expected. AFAICT there is
no nned to be smart and reset DEBCONF_SHOWOLD to its previous value.
But I cannot test d-i on my box, this is why I am reluctant to apply
such patches without intensive testing.
Alternatively DEBCONF_SHOWOLD could be set in main-menu, it seems more
logical, but requires a little more work.
Denis
Index: udpkg.c
===================================================================
RCS file: /cvsroot/d-i/debian-installer/tools/udpkg/udpkg.c,v
retrieving revision 1.47
diff -u -r1.47 udpkg.c
--- udpkg.c 24 Jan 2004 17:58:15 -0000 1.47
+++ udpkg.c 26 Jan 2004 20:55:50 -0000
@@ -85,6 +85,8 @@
}
pkg->status &= STATUS_STATUSMASK;
+ if (force_configure)
+ setenv("DEBCONF_SHOWOLD", "true", 1);
snprintf(config, sizeof(config), "%s%s.config", INFODIR, pkg->package);
if (is_file(config))
Reply to: