Bug#267227: marked as done (Minor efficiency improvement for scsi device search)
Your message dated Fri, 27 Aug 2004 12:30:44 -0400
with message-id <20040827163044.GE8060@kitenet.net>
and subject line Bug#267227: Minor efficiency improvement for scsi device search
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 21 Aug 2004 09:16:18 +0000
>From osamu@aokiconsulting.com Sat Aug 21 02:16:17 2004
Return-path: <osamu@aokiconsulting.com>
Received: from outmx014.isp.belgacom.be [195.238.2.69]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1ByRyz-0000VH-00; Sat, 21 Aug 2004 02:16:17 -0700
Received: from outmx014.isp.belgacom.be (localhost [127.0.0.1])
by outmx014.isp.belgacom.be (8.12.11/8.12.11/Skynet-OUT-2.22) with ESMTP id i7L9GFBX010887
for <submit@bugs.debian.org>; Sat, 21 Aug 2004 11:16:15 +0200
(envelope-from <osamu@aokiconsulting.com>)
Received: from dambo.lan.aokiconsulting.com (122.81-201-80.adsl.skynet.be [80.201.81.122])
by outmx014.isp.belgacom.be (8.12.11/8.12.11/Skynet-OUT-2.22) with ESMTP id i7L9G6Wq010827
for <submit@bugs.debian.org>; Sat, 21 Aug 2004 11:16:06 +0200
(envelope-from <osamu@aokiconsulting.com>)
Received: from osamu by dambo.lan.aokiconsulting.com with local (Exim 4.34)
id 1ByS5u-0002S0-5z
for submit@bugs.debian.org; Sat, 21 Aug 2004 11:23:26 +0200
Date: Sat, 21 Aug 2004 11:23:26 +0200
From: Osamu Aoki <osamu@debian.org>
To: submit@bugs.debian.org
Subject: Minor efficiency improvement for scsi device search
Message-ID: <[🔎] 20040821092326.GA9183@aokiconsulting.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="opJtzjQTFsWo+cga"
Content-Disposition: inline
X-GPG-Fingerprint: 253A 4076 6A3B CCE2 A426 DEF5 E80F C4C1 A806 1F32
User-Agent: Mutt/1.5.6+20040803i
Sender: Osamu Aoki <osamu@aokiconsulting.com>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
--opJtzjQTFsWo+cga
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Package: rootskel
Version: 0.79
Severity: wishlist
Tags: patch
Hi,
When playing with bugreporter-udeb, I had a good look at init code
in this package's src-bootfloppy directory.
find /dev/scsi
This list many useless entries. Assuming no one wish to use partition
after part9, changing above with
find /dev/scsi -name 'part?'||true
may improve code. (Or I should say, I did so in bugreporter-udeb.)
Does this make sense or it is bad idea. If bad tell me so. Then I will
fix bugreporter-udeb patch too.
Osamu
--opJtzjQTFsWo+cga
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="init.diff"
--- init.org 2004-08-21 11:08:22.000000000 +0200
+++ init 2004-08-21 11:09:51.000000000 +0200
@@ -96,7 +96,7 @@
DEVS=/dev/floppy/?
fi
if [ -d /dev/scsi ]; then
- DEVS="$DEVS `find /dev/scsi`"
+ DEVS="$DEVS `find /dev/scsi -name 'part?' || true`"
fi
else
DEVS="`find $INSTALL_MEDIA_DEV`"
--opJtzjQTFsWo+cga--
---------------------------------------
Received: (at 267227-done) by bugs.debian.org; 27 Aug 2004 16:30:26 +0000
>From joey@kitenet.net Fri Aug 27 09:30:26 2004
Return-path: <joey@kitenet.net>
Received: from kitenet.net [64.62.161.42] (postfix)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1C0jcP-0001Fw-00; Fri, 27 Aug 2004 09:30:26 -0700
Received: from dragon.kitenet.net (unknown [66.168.94.144])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(Client CN "Joey Hess", Issuer "Joey Hess" (verified OK))
by kitenet.net (Postfix) with ESMTP id 860FA1843D;
Fri, 27 Aug 2004 16:30:25 +0000 (GMT)
Received: by dragon.kitenet.net (Postfix, from userid 1000)
id 97C9A6E3FA; Fri, 27 Aug 2004 12:30:45 -0400 (EDT)
Date: Fri, 27 Aug 2004 12:30:44 -0400
From: Joey Hess <joeyh@debian.org>
To: Osamu Aoki <osamu@debian.org>, 267227-done@bugs.debian.org
Subject: Re: Bug#267227: Minor efficiency improvement for scsi device search
Message-ID: <20040827163044.GE8060@kitenet.net>
References: <[🔎] 20040821092326.GA9183@aokiconsulting.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="d8Lz2Tf5e5STOWUP"
Content-Disposition: inline
In-Reply-To: <[🔎] 20040821092326.GA9183@aokiconsulting.com>
User-Agent: Mutt/1.5.6+20040818i
Delivered-To: 267227-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
--d8Lz2Tf5e5STOWUP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Osamu Aoki wrote:
> When playing with bugreporter-udeb, I had a good look at init code
> in this package's src-bootfloppy directory.
>=20
> find /dev/scsi
>=20
> This list many useless entries. Assuming no one wish to use partition=20
> after part9, changing above with
>=20
> find /dev/scsi -name 'part?'||true
>=20
> may improve code. (Or I should say, I did so in bugreporter-udeb.)
>=20
> Does this make sense or it is bad idea. If bad tell me so. Then I will
> fix bugreporter-udeb patch too.
This won't work because floppies rarely have partitions on them at all.
Also, KISS applies. And since devfs only creates part* entries for
existing partitions, the code is already optimised.
(I'd suggest testing code before sending in patches.)
--=20
see shy jo
--d8Lz2Tf5e5STOWUP
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
iD8DBQFBL2G0d8HHehbQuO8RAhX+AJwIfViJEuQad7xXmW1oZA30QfHeGgCfWxcR
pwJLv/62S8nWhOtud3wQgJk=
=MdHx
-----END PGP SIGNATURE-----
--d8Lz2Tf5e5STOWUP--
Reply to: