[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#267168: cdrom-detect patch explanation (osamu)



Hi, 

Since my patch was not so simple but practically complete shuffle of
shell script, let me explain for the record.

Basically, old postinst script for cdrom-detect had scattered codes
failed CD mounting/umounting CD handling.

My patch send to this bug number reorders shell code to clean up this
situation with few things in mind.

 Always exit with CD  mounted when exit 0
 Always exit with CD umounted when exit 1.
 If mount error occurs, provide 2nd mount action.
   (For DMA error, 2nd mount is successful if properly umounted after
   initial try.)

First part of loop is long but the use of "continue" always returns 
here and it makes consistenthandling within while-true-do-done loop
possible.

Osamu
-- 
~\^o^/~~~ ~\^.^/~~~ ~\^*^/~~~ ~\^_^/~~~ ~\^+^/~~~ ~\^:^/~~~ ~\^v^/~~~ +++++
        Osamu Aoki <osamu@debian.org>  Brussels Belgium, GPG-key: A8061F32
 .''`.  Debian Reference: post-installation user's guide for non-developers
 : :' : http://qref.sf.net and http://people.debian.org/~osamu
 `. `'  "Our Priorities are Our Users and Free Software" --- Social Contract




Reply to: