Re: Bug#265636: Idea for Dell CDROM detect issue

[Osamu Aoki <osamu@debian.org>]

On Tue, Aug 17, 2004 at 09:54:53AM +1000, Vincent.McIntyre@csiro.au wrote:
> > 1. Patch by Vincent McIntyre (Bug#265636) has good intent but buggy
> >    as is. (I wish this type of syntax exists for "fail" function.)
> 
> That was only a sketch, as I don't have a good understanding of how such
> an error should be presented to the user by d-i.
> I think the problem with cdrom-detect.postinst is real and could be
> cleaned up quite quickly.
> I will study the code some more and try write a real patch.
> If the author would like to help, or take over, I'm happy for that too.

This part is basically your patch with fix.

+if [ "X" = "X${suite}" ]; then
+  log "Could not determine the package 'suite'. Is the cdrom OK?"
+  fail
+elif [ ! -e "/cdrom/dists/$suite/Release" ]; then
+  log "No such file '/cdrom/dists/$suite/Release'. Is the cdrom OK?"
+  fail
+fi

I changes this to elif for simplicity.