[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: r14599 - in trunk/packages/lvmcfg: . debian



I don't know anything about LVM, but wouldn't a subdirectory of /dev/ be
a way to fix this?

Martin Michlmayr wrote:
> Author: tbm
> Date: Sun May  2 10:21:33 2004
> New Revision: 14599
> 
> Modified:
>    trunk/packages/lvmcfg/debian/changelog
>    trunk/packages/lvmcfg/debian/lvmcfg-utils.templates
>    trunk/packages/lvmcfg/lvmcfg.sh
> Log:
> Print an error of a new VG name overlaps with an existing device.  Closes:
> #245700
> 
> 
> Modified: trunk/packages/lvmcfg/debian/changelog
> ==============================================================================
> --- trunk/packages/lvmcfg/debian/changelog	(original)
> +++ trunk/packages/lvmcfg/debian/changelog	Sun May  2 10:21:33 2004
> @@ -7,6 +7,8 @@
>        merely when another VG exists which contains the name of the
>        new one (that is, if the name of the new one is a subset of the
>        existing one).  Closes: #246969
> +    - Print an error of a new VG name overlaps with an existing
> +      device.  Closes: #245700
>  
>   -- Martin Michlmayr <tbm@cyrius.com>  Sun, 02 May 2004 15:57:03 +0100
>  
> 
> Modified: trunk/packages/lvmcfg/debian/lvmcfg-utils.templates
> ==============================================================================
> --- trunk/packages/lvmcfg/debian/lvmcfg-utils.templates	(original)
> +++ trunk/packages/lvmcfg/debian/lvmcfg-utils.templates	Sun May  2 10:21:33 2004
> @@ -53,6 +53,12 @@
>   The selected Volume Group name is already in use. Please choose another
>   name.
>  
> +Template: lvmcfg/vgcreate_devnameused
> +Type: error
> +_Description: Volume Group name overlaps with device name
> + The selected Volume Group name overlaps with an existing device name.
> + Please choose another name.
> +
>  Template: lvmcfg/vgdelete_names
>  Type: select
>  Choices: ${GROUPS}
> 
> Modified: trunk/packages/lvmcfg/lvmcfg.sh
> ==============================================================================
> --- trunk/packages/lvmcfg/lvmcfg.sh	(original)
> +++ trunk/packages/lvmcfg/lvmcfg.sh	Sun May  2 10:21:33 2004
> @@ -267,6 +267,16 @@
>  		return
>  	fi
>  
> +	# check if the vg name overlaps with an existing device
> +	# FIXME: d-i uses devfs while Debian doesn't, so ideally we
> +	# would also check against a regular /dev tree.
> +	if [ -e "/dev/$NAME" ]; then
> +		db_set lvmcfg/vgcreate_devnameused "false"
> +		db_input high lvmcfg/vgcreate_devnameused
> +		db_go
> +		return
> +	fi
> +
>  	for p in `echo "$PARTITIONS" | sed -e 's/,/ /g'`; do
>  		pvcreate -ff -y $p >>/var/log/messages 2>&1
>  	done
> 

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature


Reply to: