Bug#234136: marked as done (autopartkit: Using /media/cdrom instead of /cdrom)
Your message dated Fri, 16 Apr 2004 21:02:05 +0200
with message-id <E1BEYbF-0003jh-00@minerva.hungry.com>
and subject line autopartkit: Using /media/cdrom instead of /cdrom
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 21 Feb 2004 23:29:34 +0000
>From sanvila@unex.es Sat Feb 21 15:29:34 2004
Return-path: <sanvila@unex.es>
Received: from pizarro.unex.es [158.49.8.2] (postfix)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1AugYw-0005xy-00; Sat, 21 Feb 2004 15:29:34 -0800
Received: from localhost (alumnos.unex.es [158.49.17.40])
by pizarro.unex.es (Postfix/MJ-1.08) with ESMTP id C3B3FA1C40
for <submit@bugs.debian.org>; Sun, 22 Feb 2004 00:29:31 +0100 (CET)
Received: from pizarro.unex.es ([158.49.8.2])
by localhost (alumnos [158.49.17.40]) (amavisd-new, port 10024)
with ESMTP id 27738-06 for <submit@bugs.debian.org>;
Sun, 22 Feb 2004 00:29:33 +0100 (CET)
Received: from cantor.unex.es (cantor.unex.es [158.49.18.105])
by pizarro.unex.es (Postfix/MJ-1.08) with ESMTP id 63178A1C3F
for <submit@bugs.debian.org>; Sun, 22 Feb 2004 00:29:31 +0100 (CET)
Date: Sun, 22 Feb 2004 00:28:33 +0100 (CET)
From: Santiago Vila <sanvila@unex.es>
To: submit@bugs.debian.org
Subject: autopartkit: Using /media/cdrom instead of /cdrom
Message-ID: <Pine.LNX.4.58.0402212345490.19851@cantor.unex.es>
X-Debbugs-Cc: sanvila@unex.es
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Virus-Scanned: by amavisd-new-20030616-p7 (Debian) at unex.es
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_02_18
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=HAS_PACKAGE,X_DEBBUGS_CC
autolearn=no version=2.60-bugs.debian.org_2004_02_18
X-Spam-Level:
Package: autopartkit
Version: 0.79
I have been asked to add /media in base-files to follow the FHS standard,
which I have just done, but of course adding /media will not make our
system more FHS compliant unless we actually use /media/cdrom instead
of /cdrom and such.
I believe this patch is the only thing required for /media/cdrom to be
used by the install program, since APT relies on the information
written in /etc/fstab.
Please drop me a note whenever this patch or something similar is
applied (or simply reassign this bug back to the base-files package)
so that I can safely stop creating /floppy and /cdrom in base-files.
(I suspect that I could already do this, if, as it seems, this code
runs even before base-files and the other base packages are unpacked).
Thanks.
Patch follows:
diff -ru autopartkit-0.78.orig/autopartkit.c autopartkit-0.78/autopartkit.c
--- autopartkit-0.78.orig/autopartkit.c Thu Dec 18 17:21:20 2003
+++ autopartkit-0.78/autopartkit.c Sun Feb 22 00:16:53 2004
@@ -791,11 +791,14 @@
#endif /* CREATE_FSTAB */
/* Are these really needed? Who will create them if they are missing? */
- if (0 != mkdir("/target/floppy", 0755))
- autopartkit_error(1, "Unable to mkdir /target/floppy: %s",
+ if (0 != mkdir("/target/media", 0755))
+ autopartkit_error(1, "Unable to mkdir /target/media: %s",
strerror(errno));
- if (0 != mkdir("/target/cdrom", 0755))
- autopartkit_error(1, "Unable to mkdir /target/cdrom: %s",
+ if (0 != mkdir("/target/media/floppy", 0755))
+ autopartkit_error(1, "Unable to mkdir /target/media/floppy: %s",
+ strerror(errno));
+ if (0 != mkdir("/target/media/cdrom", 0755))
+ autopartkit_error(1, "Unable to mkdir /target/media/cdrom: %s",
strerror(errno));
#if defined(CREATE_FSTAB)
fstab = fopen(FSTAB, "w");
@@ -867,8 +870,8 @@
#if defined(CREATE_FSTAB)
fprintf(fstab, "%s\tnone\tswap\tsw\t\t0\t0\n",
normalize_devfs(find_partition_by_mountpoint(mountmap,"swap")));
- fprintf(fstab, "/dev/fd0\t/floppy\tauto\trw,user,noauto\t\t0\t0\n");
- fprintf(fstab, "/dev/cdrom\t/cdrom\tiso9660\tro,user,noauto\t\t0\t0\n");
+ fprintf(fstab, "/dev/fd0\t/media/floppy\tauto\trw,user,noauto\t\t0\t0\n");
+ fprintf(fstab, "/dev/cdrom\t/media/cdrom\tiso9660\tro,user,noauto\t\t0\t0\n");
fprintf(fstab, "proc\t/proc\tproc\tdefaults\t\t0\t0\n");
fclose(fstab);
---------------------------------------
Received: (at 234136-done) by bugs.debian.org; 16 Apr 2004 19:02:37 +0000
>From pere@gigs.hungry.com Fri Apr 16 12:02:37 2004
Return-path: <pere@gigs.hungry.com>
Received: from 217-13-7-10.dd.nextgentel.com (minerva.hungry.com) [217.13.7.10]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1BEYbk-0004KE-00; Fri, 16 Apr 2004 12:02:37 -0700
Received: from pere by minerva.hungry.com with local (Exim 3.35 #1 (Debian))
id 1BEYbF-0003jh-00; Fri, 16 Apr 2004 21:02:05 +0200
To: 234136-done@bugs.debian.org
Subject: Re: autopartkit: Using /media/cdrom instead of /cdrom
From: Petter Reinholdtsen <pere@hungry.com>
Message-Id: <E1BEYbF-0003jh-00@minerva.hungry.com>
Sender: Petter Reinholdtsen <pere@gigs.hungry.com>
Date: Fri, 16 Apr 2004 21:02:05 +0200
Delivered-To: 234136-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-1.5 required=4.0 tests=BAYES_10 autolearn=no
version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
X-CrossAssassin-Score: 1
autopartkit no longer generate fstab. It is done by the package
partconf-mkfstab. I'm closing this bug. If partconf-mkfstab fail to
do it properly, you should reopen and reassign this bug to
partconf-mkfstab.
Reply to: