[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#219469: marked as done (ddetect: Debconf templates polishing)



Your message dated Tue, 09 Dec 2003 16:17:19 -0500
with message-id <E1ATpEN-0007mP-00@auric.debian.org>
and subject line Bug#219469: fixed in ddetect 0.58
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 6 Nov 2003 19:15:49 +0000
>From bubulle@kheops.frmug.org Thu Nov 06 13:15:47 2003
Return-path: <bubulle@kheops.frmug.org>
Received: from lns-th2-5f-81-56-227-253.adsl.proxad.net (kheops.homeunix.org) [81.56.227.253] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1AHpbd-00048O-00; Thu, 06 Nov 2003 13:15:46 -0600
Received: from localhost (localhost [127.0.0.1])
	by kheops.homeunix.org (Postfix) with ESMTP
	id D0CBA4061; Thu,  6 Nov 2003 20:15:43 +0100 (CET)
Received: from kheops.homeunix.org ([127.0.0.1])
	by localhost (kheops [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 25408-03; Thu, 6 Nov 2003 20:15:30 +0100 (CET)
Received: from mykerinos.kheops.frmug.org (mykerinos.kheops.frmug.org [192.168.1.3])
	by kheops.homeunix.org (Postfix) with ESMTP
	id 76FB34058; Thu,  6 Nov 2003 20:15:29 +0100 (CET)
Received: by mykerinos.kheops.frmug.org (Postfix, from userid 7426)
	id 135BFD065; Thu,  6 Nov 2003 17:34:22 +0100 (CET)
Content-Type: multipart/mixed; boundary="===============1330218351=="
MIME-Version: 1.0
From: Christian Perrier <bubulle@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: ddetect: Debconf templates polishing
X-Mailer: reportbug 2.36
Date: Thu, 06 Nov 2003 17:34:22 +0100
Message-Id: <20031106163422.135BFD065@mykerinos.kheops.frmug.org>
X-Virus-Scanned: by amavisd-new-20030616-p5 (Debian) at kheops.frmug.org
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-7.9 required=4.0
	tests=HAS_PACKAGE,PATCH_UNIFIED_DIFF
	autolearn=ham version=2.53-bugs.debian.org_2003_11_03
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_11_03 (1.174.2.15-2003-03-30-exp)

This is a multi-part MIME message sent by reportbug.

--===============1330218351==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: ddetect
Severity: normal
Tags: patch

As usual, the following changes will make debconf templates more consistent
with other modules templates.

Detailed rationale:

diff -Nru ddetect/debian/ethdetect.templates ddetect.new/debian/ethdetect.templates
--- ddetect/debian/ethdetect.templates	2003-11-06 17:10:22.000000000 +0100
+++ ddetect.new/debian/ethdetect.templates	2003-11-06 07:10:07.000000000 +0100
@@ -2,34 +2,33 @@
 Type: select
 _Choices: ${CHOICES}, none of the above
 Default: none of the above
-_Description: What module does your ethernet card require?
- This is a list of modules that I know about. Choose the module from the
- list that supports your card. If none of the modules do, you may need to
- load additional modules from a driver floppy; choose none of the above.
+_Description: Module needed by your ethernet card:
+ Please choose amon the known modules which one supports your card. If
+ none of the modules do, you may need to load additional modules from
+ a driver floppy. Then choose the "none of the above" option.

1) This is a string template, so avoid using a question and use a "prompt"
2) The first person use is to be avoided. So, reformulation of the extended
description.


 Template: ethdetect/cannot_find
 Type: error
-_Description: Cannot detect your ethernet card.
- Your ethernet card was not found.
+_Description: Ethernet card not found
+ No Ethernet card was found on the system.

1) Short description is a title
2) Nothing says that there actually *is* an Ethernet card...so avoid "your".

s/ethernet/Ethernet, by the way


 Template: ethdetect/modprobe_error
 Type: note
-_Description: An error occured while running '${CMD_LINE_PARAM}'
- Something must have gone wrong.
+_Description: Error while running '${CMD_LINE_PARAM}'

Well, there has been an error, so probably, yes, something went wrong..:-)

Apart from being useles, the sentence is a bit trivial, which does not sound
very professionnal to me.



 Template: ethdetect/module_params
 Type: string
-_Description: Please enter any additional parameters for module ${MODULE}
+_Description: Additional parameters for module ${MODULE}:
  Some modules accept load-time parameters to customize their operation.
  These parameters are often I/O port and IRQ numbers that vary from machine
- to machine and cannot be determined from the hardware. An example string
- looks something like "IRQ=7 IO=0x220"
+ to machine and cannot be determined from the hardware. A typical parameter
+ string is "IRQ=7 IO=0x220".


1) String template, so prompt....and possibly *short* prompt...
2) I feel this better English, but maybe someone will find something even
better



 Template: ethdetect/detection_type
 Type: boolean
 Default: true
-_Description: Would you like me to try to detect hardware?
- I can automatically detect some hardware.  If you don't use
+_Description: Try to detect hardware?
+ Some hardware may be automatically detected.  If you don't use
  automatic detection, you will be prompted to identify your hardware.

1) Who is "me"? The computer is not a person...So let's be more factual
2) Ditto.



 Template: debian-installer/ethdetect/title
diff -Nru ddetect/debian/hw-detect.templates ddetect.new/debian/hw-detect.templates
--- ddetect/debian/hw-detect.templates	2003-11-06 17:10:22.000000000 +0100
+++ ddetect.new/debian/hw-detect.templates	2003-11-06 17:29:51.000000000 +0100
@@ -1,6 +1,6 @@
 Template: hw-detect/title
 Type: text
-_Description: Detecting HW and loading kernel modules
+_Description: Detecting hardware and loading kernel modules

1) Avoid jargon and obscure acronyms


 Template: hw-detect/missing_modules
 Type: error
@@ -18,7 +18,7 @@
 
 Template: hw-detect/detect_progress_step
 Type: text
-_Description: Detecting hardware, please wait
+_Description: Detecting hardware, please wait...

Progress step


 Template: hw-detect/load_progress_title
 Type: text
@@ -26,7 +26,7 @@
 
 Template: hw-detect/load_progress_step
 Type: text
-_Description: Loading module '${MODULE}' for '${CARDNAME}'
+_Description: Loading module '${MODULE}' for '${CARDNAME}'...

Ditto

 Template: hw-detect/load_progress_skip_step
 Type: text
@@ -34,7 +34,7 @@
 
 Template: hw-detect/module_params
 Type: string
-_Description: Please enter any additional parameters for module ${MODULE}
+_Description: Additional parameters for module ${MODULE}:
  Some modules accept load-time parameters to customize their operation.
  These parameters are often I/O port and IRQ numbers that vary from machine
  to machine and cannot be determined from the hardware. An example string
@@ -44,5 +44,5 @@

1) String prompt-->shorten



 Template: hw-detect/modprobe_error
 Type: error
-_Description: An error occured while running '${CMD_LINE_PARAM}'
- Something must have gone wrong.
+_Description: Error while running '${CMD_LINE_PARAM}'
+

Same as above....

-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux mykerinos 2.4.22 #2 Mon Sep 29 15:12:10 CEST 2003 i686
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (ignored: LC_ALL set to fr_FR.UTF-8)


--===============1330218351==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="patch"

diff -Nru ddetect/debian/ethdetect.templates ddetect.new/debian/ethdetect.templates
--- ddetect/debian/ethdetect.templates	2003-11-06 17:10:22.000000000 +0100
+++ ddetect.new/debian/ethdetect.templates	2003-11-06 07:10:07.000000000 +0100
@@ -2,34 +2,33 @@
 Type: select
 _Choices: ${CHOICES}, none of the above
 Default: none of the above
-_Description: What module does your ethernet card require?
- This is a list of modules that I know about. Choose the module from the
- list that supports your card. If none of the modules do, you may need to
- load additional modules from a driver floppy; choose none of the above.
+_Description: Module needed by your ethernet card:
+ Please choose amon the known modules which one supports your card. If
+ none of the modules do, you may need to load additional modules from
+ a driver floppy. Then choose the "none of the above" option.
 
 Template: ethdetect/cannot_find
 Type: error
-_Description: Cannot detect your ethernet card.
- Your ethernet card was not found.
+_Description: Ethernet card not found
+ No Ethernet card was found on the system.
 
 Template: ethdetect/modprobe_error
 Type: note
-_Description: An error occured while running '${CMD_LINE_PARAM}'
- Something must have gone wrong.
+_Description: Error while running '${CMD_LINE_PARAM}'
 
 Template: ethdetect/module_params
 Type: string
-_Description: Please enter any additional parameters for module ${MODULE}
+_Description: Additional parameters for module ${MODULE}:
  Some modules accept load-time parameters to customize their operation.
  These parameters are often I/O port and IRQ numbers that vary from machine
- to machine and cannot be determined from the hardware. An example string
- looks something like "IRQ=7 IO=0x220"
+ to machine and cannot be determined from the hardware. A typical parameter
+ string is "IRQ=7 IO=0x220".
 
 Template: ethdetect/detection_type
 Type: boolean
 Default: true
-_Description: Would you like me to try to detect hardware?
- I can automatically detect some hardware.  If you don't use
+_Description: Try to detect hardware?
+ Some hardware may be automatically detected.  If you don't use
  automatic detection, you will be prompted to identify your hardware.
 
 Template: debian-installer/ethdetect/title
diff -Nru ddetect/debian/hw-detect.templates ddetect.new/debian/hw-detect.templates
--- ddetect/debian/hw-detect.templates	2003-11-06 17:10:22.000000000 +0100
+++ ddetect.new/debian/hw-detect.templates	2003-11-06 17:29:51.000000000 +0100
@@ -1,6 +1,6 @@
 Template: hw-detect/title
 Type: text
-_Description: Detecting HW and loading kernel modules
+_Description: Detecting hardware and loading kernel modules
 
 Template: hw-detect/missing_modules
 Type: error
@@ -18,7 +18,7 @@
 
 Template: hw-detect/detect_progress_step
 Type: text
-_Description: Detecting hardware, please wait
+_Description: Detecting hardware, please wait...
 
 Template: hw-detect/load_progress_title
 Type: text
@@ -26,7 +26,7 @@
 
 Template: hw-detect/load_progress_step
 Type: text
-_Description: Loading module '${MODULE}' for '${CARDNAME}'
+_Description: Loading module '${MODULE}' for '${CARDNAME}'...
 
 Template: hw-detect/load_progress_skip_step
 Type: text
@@ -34,7 +34,7 @@
 
 Template: hw-detect/module_params
 Type: string
-_Description: Please enter any additional parameters for module ${MODULE}
+_Description: Additional parameters for module ${MODULE}:
  Some modules accept load-time parameters to customize their operation.
  These parameters are often I/O port and IRQ numbers that vary from machine
  to machine and cannot be determined from the hardware. An example string
@@ -44,5 +44,5 @@
 
 Template: hw-detect/modprobe_error
 Type: error
-_Description: An error occured while running '${CMD_LINE_PARAM}'
- Something must have gone wrong.
+_Description: Error while running '${CMD_LINE_PARAM}'
+

--===============1330218351==--

---------------------------------------
Received: (at 219469-close) by bugs.debian.org; 9 Dec 2003 21:26:55 +0000
>From katie@auric.debian.org Tue Dec 09 15:26:55 2003
Return-path: <katie@auric.debian.org>
Received: from auric.debian.org [206.246.226.45] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1ATpL7-0003oF-00; Tue, 09 Dec 2003 15:24:17 -0600
Received: from katie by auric.debian.org with local (Exim 3.35 1 (Debian))
	id 1ATpEN-0007mP-00; Tue, 09 Dec 2003 16:17:19 -0500
From: Joey Hess <joeyh@debian.org>
To: 219469-close@bugs.debian.org
X-Katie: $Revision: 1.43 $
Subject: Bug#219469: fixed in ddetect 0.58
Message-Id: <E1ATpEN-0007mP-00@auric.debian.org>
Sender: Archive Administrator <katie@auric.debian.org>
Date: Tue, 09 Dec 2003 16:17:19 -0500
Delivered-To: 219469-close@bugs.debian.org

Source: ddetect
Source-Version: 0.58

We believe that the bug you reported is fixed in the latest version of
ddetect, which is due to be installed in the Debian FTP archive:

archdetect_0.58_i386.udeb
  to pool/main/d/ddetect/archdetect_0.58_i386.udeb
ddetect_0.58.dsc
  to pool/main/d/ddetect/ddetect_0.58.dsc
ddetect_0.58.tar.gz
  to pool/main/d/ddetect/ddetect_0.58.tar.gz
ethdetect_0.58_all.udeb
  to pool/main/d/ddetect/ethdetect_0.58_all.udeb
hw-detect-full_0.58_all.udeb
  to pool/main/d/ddetect/hw-detect-full_0.58_all.udeb
hw-detect_0.58_all.udeb
  to pool/main/d/ddetect/hw-detect_0.58_all.udeb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 219469@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joey Hess <joeyh@debian.org> (supplier of updated ddetect package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue,  9 Dec 2003 15:46:32 -0500
Source: ddetect
Binary: hw-detect-full archdetect hw-detect ethdetect
Architecture: source i386 all
Version: 0.58
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Joey Hess <joeyh@debian.org>
Description: 
 archdetect - Hardware architect detector (udeb)
 ethdetect  - Detect network hardware and load kernel drivers for it (udeb)
 hw-detect  - Detect hardware and load kernel drivers for it (udeb)
 hw-detect-full - Detect hardware and load kernel drivers for it (full version) (udeb)
Closes: 219469 221648
Changes: 
 ddetect (0.58) unstable; urgency=low
 .
   * Joey Hess
     - Remove the bogus "false" from the end of the modprobe error message
       display.
     - Sort the list of modules for manual selection.
     - Use register-module to register modules for ide and scsi CDROMS,
       so they will be available for base-config.
     - Use register-module to register any module parameters that are entered
       by the user.
     - Fix ethdetect to not write kernel module parameters to
       /target/etc/modules; instead use register-module here too.
     - Add a versioned dep on rootskel.
     - Based on user reports, users are very confused to see the missing
       modules dialog for stuff like ide-floppy, which is both unavailable
       and not autodetected. So leave off non-autodetectable modules from the
       missing modules message.
   * Claus Hindsgaul
     - Update da (Danish) translation.
   * Konstantinos Margaritis
     - Initial Greek translation (el.po)
   * Christian Perrier/Chris Tillman
     - Refined and standardized templates. Closes: #219469
   * Safir Å eÄ?eroviÄ?
     - Update Bosnian translation.
   * Christian Perrier
     - Update French translation.
   * Miroslav Kure
     - Update Czech translation.
   * Jordi Mallach
     - Update Catalan translation.
   * Kenshi Muto
     - Update Japanese translation (ja.po)
   * Ilgiz Kalmetev
     - Update Russian translation. Closes: #221648.
   * André Luís Lopes
     - Update pt_BR (Brazilian Portuguese) translation.
   * Thiemo Seufer
     - Add support for mips, mipsel to archdetect.
     - Remove unused #includes.
     - Unify code formatting.
     - Add CFLAGS for warnings and space optimization.
Files: 
 5cf3f18d94157e222ffec11e25ba62cc 702 debian-installer standard ddetect_0.58.dsc
 614a5c45d16d22a231309dc567ae15f3 38083 debian-installer standard ddetect_0.58.tar.gz
 265fa8f9fc453444fed472f6c2c175e0 8842 debian-installer standard hw-detect_0.58_all.udeb
 b567bf22c74156587eacecfbadf163dd 5630 debian-installer optional ethdetect_0.58_all.udeb
 0485d44628d1f22a2ceb1852846b0490 1100 debian-installer standard hw-detect-full_0.58_all.udeb
 104eef78ed0abd7b0daa354c7af653e6 2298 debian-installer standard archdetect_0.58_i386.udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQE/1jpa2tp5zXiKP0wRAm18AJ95jWpXpu6eQxztvXDuJf+RclQH0gCgv19R
+hhBtOoWM2JLeoEyjFJHtMg=
=oZWC
-----END PGP SIGNATURE-----



Reply to: