[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#201214: debconfclient.h macros waste space in binary



Petter Reinholdtsen wrote:
> [Joey Hess]
> > #define debconf_input(_client, _priority, _question) \
> >     _client->commandf(_client, "INPUT %s %s", _priority, _question)
> 
> Shouldn't it be ', NULL' at the end of this argument list?

No, it's commandf.

The bug is not accurate; "INPUT %s %s" is not much longer than
"INPUT". The real problem is the code in d-i that does things like:

   debconf->commandf("INPUT high", foo, NULL);
   debconf->commandf("INPUT medium", bar, NULL);

Nearly any whitespace used like that wastes memory. Can anyone think of
a way to error out at compile time on those?

-- 
see shy jo

Attachment: pgpqDB83dKWeG.pgp
Description: PGP signature


Reply to: