[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Trivial patch + questions



reopen 189054
thanks

Hi...
On Mon, 12 May 2003 02:57 am, Joe Nahmias wrote:
> Peter Hawkins wrote:
> > Hi...
>
> Hello Peter!
>
> > Am I right in thinking that ethernet card detection is broken right now?
> > The detection appears not to detect an intel etherexpress pro/100 card
> > (whereas it worked fine a couple of weeks ago).
>
> This should be fixed by now, see bug #189054 which was fixed in
> ethdetect 0.24.

Relevant package versions in my build are shown below.

I traced down the cause of my problem. There are two problems actually.
a)
I traced the problem down to the fact that ethdetect calls hw-detect, but 
hw-detect doesn't actually try to detect ethernet cards. It calls discover 
with the device options 'scsi cdrom', but no 'ethernet', so it doesn't try to 
detect ethernet cards. Patch for hw-detect is attached.

a) Bug #189054 has regressed.
From /var/log/messages on the running installer:
/bin/hw-detect: Detected load module 'eepro100' for 'Intel Corporation 82557 
[Ethernet Pro 100]'
/bin/hw-detect: Trying to load module 'eepro100'

The module is, of course, called e100, so it tries and fails. Apparently the 
discover-data (non-full version) is wrong. I am reopening the bug against 
ethdetect for this reason.

=)
Peter

udebs used for my build were:
anna_0.028_i386.udeb
busybox-udeb_1%3a0.60.5-2_i386.udeb
cdebconf-newt-udeb_0.37_i386.udeb
cdebconf-udeb_0.37_i386.udeb
cdrom-detect_0.22_all.udeb
cdrom-retriever_0.07_all.udeb
choose-mirror_0.013_i386.udeb
dash-udeb_0.4.17_i386.udeb
dhcp-client-udeb_2.0pl5-15_i386.udeb
discover-data-udeb_1.2002.08.21-1.1_all.udeb
discover-udeb_1.5-1.4_i386.udeb
di-utils-shell_0.20_i386.udeb
ethdetect_0.28_all.udeb
floppy-retriever_0.05_all.udeb
hw-detect_0.28_all.udeb
input-modules-2.4.20-1-386-udeb_2.4.20-8_i386.udeb
isa-pnp-modules-2.4.20-1-386-udeb_2.4.20-8_i386.udeb
kernel-image-2.4.20-1-386-udeb_2.4.20-8_i386.udeb
languagechooser_0.021_all.udeb
libc-udeb_2.3.1-17_i386.udeb
main-menu_0.029_i386.udeb
modutils-basic_2.4.21-2_i386.udeb
netcfg-dhcp_0.23_i386.udeb
netcfg-static_0.23_i386.udeb
net-retriever_0.016_i386.udeb
nic-modules-2.4.20-1-386-udeb_2.4.20-8_i386.udeb
nic-modules-shared-2.4.20-1-386-udeb_2.4.20-7_i386.udeb
nic-shared-modules-2.4.20-1-386-udeb_2.4.20-8_i386.udeb
pump-udeb_0.8.14-2_i386.udeb
rootskel_0.28_i386.udeb
slang1a-utf8-udeb_1.4.5-2_i386.udeb
socket-modules-2.4.20-1-386-udeb_2.4.20-8_i386.udeb
udpkg_0.013_i386.udeb
usb-modules-2.4.20-1-386-udeb_2.4.20-8_i386.udeb

Index: tools/ddetect/hw-detect.sh
===================================================================
RCS file: /cvs/debian-boot/debian-installer/tools/ddetect/hw-detect.sh,v
retrieving revision 1.10
diff -u -3 -p -r1.10 hw-detect.sh
--- tools/ddetect/hw-detect.sh	11 May 2003 12:03:33 -0000	1.10
+++ tools/ddetect/hw-detect.sh	12 May 2003 02:14:01 -0000
@@ -79,7 +79,7 @@ discover_hw () {
     else
         # must be Discover 1.x
         /sbin/discover --format="%m\t%V %M\n" \
-            --disable-all --enable=pci,ide,scsi,pcmcia scsi cdrom |
+            --disable-all --enable=pci,ide,scsi,pcmcia scsi cdrom ethernet |
 	  sed 's/ $//'
     fi
 }

Reply to: