[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Default disk partition table type?



On Tue, Dec 10, 2002 at 11:32:28PM +0100, Petter Reinholdtsen wrote:
> [Guido Guenther]
> >> I believe the available values are "bsd", "loop", "mac", "msdos",
> >> "pc98" and "sun".  I got the values from the parted documentation.
> > big endian mips currently only uses SGI disklabels.
> 
> Which of the parted disk label names is this?  'bsd'?  Or is it not
> supported by parted?
According to the source code there's sgi disklabel support in parted
1.6.3 (although incorreclty called 'mips'). Shouldn't we do:

--- libparted/disk_mips.c.orig	Wed Dec 11 12:13:54 2002
+++ libparted/disk_mips.c	Wed Dec 11 12:14:00 2002
@@ -905,7 +905,7 @@
 
 static PedDiskType mips_disk_type = {
 	next:		NULL,
-	name:		"mips",
+	name:		"sgi-mips",
 	ops:		&mips_disk_ops,
 	features:	PED_DISK_TYPE_PARTITION_NAME | PED_DISK_TYPE_EXTENDED
 };

since there are many mips based systems not using sgi disklabels. The
autopartkit should check for __MIPSEB__.
Regards,
 -- Guido

Attachment: pgpRYTg4Fl0vx.pgp
Description: PGP signature


Reply to: