[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: woody boot-floppies 3.0.9 i386 for testing



#include <hallo.h>
Adam Di Carlo wrote on Tue Aug 07, 2001 um 11:31:52AM:

> boot-floppies (3.0.9) unstable; urgency=low
> 

In addition, some thinks I would like to change (some extracted changes
from my ext3 BF set):

Why this '[^a-zA-Z]'? This make the script ignore my "-Custom*" version
of the kernel:
 
--- boot-floppies-3.0.8.orig/common.sh
+++ boot-floppies-3.0.8/common.sh
@@ -91,7 +91,7 @@
         # package name might  have '=' or /', so get rid of that
         pkg=${pkg%%[/=]*}
         # force files in the 'updates' dir to alway override
-	for j in `pwd`/updates/${pkg}_[^a-zA-Z]*.deb; do
+	for j in `pwd`/updates/${pkg}_*.deb; do
             if [ -f "$j" ]; then
 		f="$f $j"
             fi

We could increase the size of the ramdisk, I did not get any problems
with 4MB:

--- boot-floppies-3.0.8.orig/make/i386.rules
+++ boot-floppies-3.0.8/make/i386.rules
@@ -17,11 +17,11 @@
 root1440%.bin: 	resc1440%.bin
 
 rootide.bin:		rootdisk.sh moduleside.tgz
-	$(ROOTCMD) ./rootdisk.sh "ide" $(archive) 3200 $(debianversion) "" $(LINGUA) "$(FONT)" $(SFONT)
+	$(ROOTCMD) ./rootdisk.sh "ide" $(archive) 4000 $(debianversion) "" $(LINGUA) "$(FONT)" $(SFONT)
 
 rootidepci.bin:		rootdisk.sh modulesidepci.tgz
-	$(ROOTCMD) ./rootdisk.sh "idepci" $(archive) 3200 $(debianversion) "" $(LINGUA) "$(FONT)" $(SFONT)
+	$(ROOTCMD) ./rootdisk.sh "idepci" $(archive) 4000 $(debianversion) "" $(LINGUA) "$(FONT)" $(SFONT)
 
 rootcompact.bin:	rootdisk.sh modulescompact.tgz
-	$(ROOTCMD) ./rootdisk.sh "compact" $(archive) 3200 $(debianversion) "" $(LINGUA) "$(FONT)" $(SFONT)
+	$(ROOTCMD) ./rootdisk.sh "compact" $(archive) 4000 $(debianversion) "" $(LINGUA) "$(FONT)" $(SFONT)

This is weird... As far as I can see, the function is_fstype returns the
value of strncmp. But strncmp returns 0 for equal no 1/-1 for not equal.
So this should be changed (the author of baseconfig.c may correct this):

--- boot-floppies-3.0.8.orig/utilities/dbootstrap/baseconfig.c
+++ boot-floppies-3.0.8/utilities/dbootstrap/baseconfig.c
@@ -250,7 +250,7 @@
   else {
 	/* this no longer seems too intelligent? */
 	status = is_fstype ("/target", "reiserfs");
-        if ( status == -1 )
+        if ( status != 0)
 	{
 	  perrorBox (_("Could not determine FS type of /, assuming ext2"));
 	  status = 0; /* no match, thus ext2 */

This may be interessting for Herbert Xu too. Why do we use "msdos" as
the default DOS-like filesystem in the kernel? It doesn't support long
filenames, and when built-in, it is used first while auto-detecting
fs-type. I suggest to drop msdos support from the kernel (or compile as
module, since sometimes needed) and use vfat instead:

--- boot-floppies-3.0.8.orig/utilities/dbootstrap/choose_medium.c
+++ boot-floppies-3.0.8/utilities/dbootstrap/choose_medium.c
@@ -35,7 +35,7 @@
 #if #cpu(sparc) || #cpu(powerpc)
 const char *fs_type_tab[] = { "ext2", NULL };
 #else
-const char *fs_type_tab[] = { "msdos", "ext2", NULL };
+const char *fs_type_tab[] = { "vfat", "fat", "msdos", "ext2", NULL };
 #endif
 
 /* Return Values:

Does it make sense to force ext2? The reiserfs-case is caught before, so
we can leave the kernel the freedom of choosing between ext2 and others
(eg. ext3):

--- boot-floppies-3.0.8.orig/utilities/dbootstrap/partition_config.c
+++ boot-floppies-3.0.8/utilities/dbootstrap/partition_config.c
@@ -481,9 +489,10 @@
     }
   }
   else /* ext2 */
-  { /* this block is the same as the one above */
-    sprintf(prtbuf, "mount -t %s %s %s",
-	  type, partition->name, real_mount_point);
+  { /* this block is the same as the one above
+     will detect ext3 or ext2 automaticaly */
+    sprintf(prtbuf, "mount -t auto %s %s",
+	   partition->name, real_mount_point);
     status = execlog(prtbuf, LOG_INFO);
   }
 
Gruss/Regards,
Eduard. 
-- 
Anwender1: Mein WIN95 ist in 6 Monaten noch NIE abgestürzt...
Anwender2: Ein halbes Jahr ohne Strom - das ist hart!



Reply to: