[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: alpha boot-floppies



tad@omoikane.co.jp wrote:
> 
> Adam Di Carlo wrote:
> > No, the system breaks when the attached patch is applied, and works
> > when it doesn't, on a fully, 100% up-to-date system.

> > --- mklibs.sh Wed Oct 20 16:01:49 1999
> > +++ mklibs.sh.alpha   Thu Dec  2 06:52:57 1999
> > @@ -413,9 +413,8 @@
> >      exit 1
> >    fi
> >    $objdump --syms "$@" 2>/dev/null \
> > -    | sed -e '/^........ ..   .. \*UND\*     [0-9a-f]....... *[^ ]*$/d' \
> > -    | sed -n 's/^........ \(g \| w\)   .. .* [0-9a-f]....... *\([^ ]*\)$/\2/p'
> > -#    | sed -n 's/^........ \(g \| w\)   .. .*        [0-9a-f]....... *\([^ @]*\).*$/\2/p'
> > +    | sed -e '/^[0-9a-f]\+ ..   .. \*UND\*     [0-9a-f]\+ *[^ ]*$/d' \
> > +    | sed -n 's/^[0-9a-f]\+ \(g \| w\)   .. .*[0-9a-f]\+ \(0x88\)\? *\([^ ]*\)\$/\3/p'
> > }
> 
> Ok, I understood problem.
> Your patch above and my patch differ in line:
> 
> > +    | sed -e '/^[0-9a-f]\+ ..   .. \*UND\*     [0-9a-f]\+ *[^ ]*$/d' \
>                                              ^^^^^
> where ^^^^ is tab in my patch and spaces in your patch.


Yeah, that's really bad code here, because there are "hidden" tabs.
If anybody has a suggestion how to make the tab more visible here,please
let me know. Probably the objdump regex should be wholly different, but
note that objdump output is not really standardized and keeps changing
(maybe I should ask the objdump authors to have an option for the
seperato
of fields).

Thanks,
Marcus


Reply to: