[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#802399: RFS: localehelper/0.1.4-1 [ITP] - Locale helper tool



I don't intend to sponsor this package, but here's my review:

* Jonathan Ulrich Horn <debian@autoit4you.de>, 2015-10-19, 23:34:
http://mentors.debian.net/debian/pool/main/l/localehelper/localehelper_0.1.4-1.dsc

Priority should probably be optional, not extra.

Short description is not a sentence, just a phrase, so it shouldn't start with a capital letter.

I'd recommend using https:// in Vcs-Git.

libperl-critic-perl is in Build-Depends, but it doesn't seem to be used at build time.

Please honor DEB_BUILD_OPTIONS=nocheck.

I'd remove most of the comments from debian/rules. They are distracting and not really relevant to this package.

I'd also remove "DPKG_EXPORT_BUILDFLAGS = 1" and "include /usr/share/dpkg/default.mk", because it doesn't have any effect on this package.

dh_auto_* calls are no-ops here, so I'd remove them too.

You might want to strip trailing space after "dh $@". :)

* Initial release (Closes: #801064)

Hmm, was ITP bug CCed to debian-devel? I didn't see it there...

--
Jakub Wilk


Reply to: