Bug#751875: RFS: gorm.app/1.2.20-1

[Yavor Doganov <yavor@gnu.org>]

At Sun, 3 Aug 2014 21:18:24 +0200,
Paul Gevers wrote:
> I have several (in random order) remarks:
> 
> I find the man page rather short, is it reasonable to improve it?

I have extended it as much as I could.

> I didn't check yet, but aren't you know installing the d/docs adn
> d/examples files into all packages? Is that what you want?

They're installed only in the gorm.app package which is what I want.

> Did you already forwarded your patches?

No; link-libs will be rejected (for some reason upstream considers it
a feature not to link the dynamically loadable modules), so I have to
rework it somehow.  Regarding texinfo-fixes, I'd like to fix more
(minor) issues before forwarding upstream but have postponed that as
there are currently more important problems to deal with.

> The clean target doesn't work in my normal workspace, maybe add a
> hyphen in front of the "$(MAKE) -C Documentation distclean" command
> or is there something else missing?

Could you please post the error message?  Any errors should be ignored
by gnustep-make by default.  Adding a hyphen triggers a lintian
warning, so I've added a check for the presence of the .info file
instead.

> Most importantly, I am not convinced yet, that the debian/copyright file
> is a proper description of the situation. Some items that I saw and I
> like clarification for:
> + in the README: Icons - Mostly by Andrew Lindsay.   Gorm application
> icon by Jesse Ross. Code -  GormViewKnobs.m adapted from code by Gerrit
> van Dyk.

I cannot put this in debian/copyright as that file should document
copyright, not authorship.  Gorm is an official GNU package and
copyright is assigned to the FSF.

> + GormImageInspector/GormNSSplitViewInspector and many more contain the
> header "All Rights reserved". Please check with upstream.

These files are most probably instantiated with Gorm itself which puts
this notice.  I'll ask upstream to replace it with the actual license
notice.  "All rights reserved" has no legal weight anyway.

> + Documentation/COPYING and most GNUmakefiles say GPL-2+

The former is correct.  Apparently most makefiles were omitted during
the switch to GPL-3+.  I'll ask upstream to rectify this.

> The d/copyright file mentions Examples/* but that does not exist in the
> root. So, what do you mean.

Thanks, it should have been Documentation/Examples/*.  Fixed.