Re: [PATCH v1] block: switch numa_node to int in blk_mq_hw_ctx and init_request
- To: Mateusz Nowicki <mateusz.nowicki@posteo.net>
- Cc: Caleb Sander Mateos <csander@purestorage.com>, Sung-woo Kim <iam@sung-woo.kim>, Josef Bacik <josef@toxicpanda.com>, Alasdair Kergon <agk@redhat.com>, Mike Snitzer <snitzer@kernel.org>, Mikulas Patocka <mpatocka@redhat.com>, Benjamin Marzinski <bmarzins@redhat.com>, Ulf Hansson <ulfh@kernel.org>, Richard Weinberger <richard@nod.at>, Zhihao Cheng <chengzhihao1@huawei.com>, Miquel Raynal <miquel.raynal@bootlin.com>, Vignesh Raghavendra <vigneshr@ti.com>, Sven Peter <sven@kernel.org>, Janne Grunau <j@jannau.net>, Neal Gompa <neal@gompa.dev>, Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>, Justin Tee <justin.tee@broadcom.com>, Naresh Gottumukkala <nareshgottumukkala83@gmail.com>, Paul Ely <paul.ely@broadcom.com>, Chaitanya Kulkarni <kch@nvidia.com>, "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, Thomas Fourier <fourier.thomas@gmail.com>, Al Viro <viro@zeniv.linux.org.uk>, Luke Wang <ziniu.wang_1@nxp.com>, Kees Cook <kees@kernel.org>, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, nbd@other.debian.org, dm-devel@lists.linux.dev, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org
- Subject: Re: [PATCH v1] block: switch numa_node to int in blk_mq_hw_ctx and init_request
- From: Jens Axboe <axboe@kernel.dk>
- Date: Tue, 26 May 2026 10:37:20 -0600
- Message-id: <[🔎] 177981344077.464267.4670805396521914701.b4-ty@b4>
- In-reply-to: <[🔎] 20260523125210.272274-1-mateusz.nowicki@posteo.net>
- References: <[🔎] 20260523125210.272274-1-mateusz.nowicki@posteo.net>
On Sat, 23 May 2026 12:52:35 +0000, Mateusz Nowicki wrote:
> numa_node in blk_mq_hw_ctx and the matching argument of
> blk_mq_ops::init_request can be NUMA_NO_NODE (-1). Declared as
> unsigned int, NUMA_NO_NODE becomes UINT_MAX and walks off
> nvme_dev::descriptor_pools[] on CONFIG_NUMA=n [1].
>
> Switch the field and the callback prototype to int and update all
> in-tree init_request implementations. No functional change:
> cpu_to_node(), kmalloc_node() and blk_alloc_flush_queue() already
> take int.
>
> [...]
Applied, thanks!
[1/1] block: switch numa_node to int in blk_mq_hw_ctx and init_request
commit: 65e1c8f96ad1a1f3b72e8a91d1341d570f91d985
Best regards,
--
Jens Axboe
Reply to: